Fix printCallRDiagnostics masking the original callR error - #14843
Open
cderv wants to merge 1 commit into
Open
Conversation
printCallRDiagnostics re-enters R discovery (checkRBinary -> rBinaryPath) to explain a callR failure. A throw during that re-entry would propagate and replace the original callR error the caller already reported, hiding the real cause from the user. Wrap the body in try/catch and warn on diagnostics failure instead.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When callR fails, printCallRDiagnostics re-enters R discovery (checkRBinary -> rBinaryPath) to explain why. A throw during that re-entry propagates and replaces the original callR error, so the user only sees a failure from the diagnostics code instead of the real cause.
This is the second concern raised on #14775, alongside the malformed
QUARTO_Rcrash fixed in #14790:rBinaryPathno longer throws for that specific case, butprintCallRDiagnosticsitself was never hardened against a throw anywhere in the discovery chain it re-enters.Wraps
printCallRDiagnostics's body in try/catch and logs a warning on diagnostics failure instead of throwing over the original error.Related to #14775