Fix vacuous-pass bugs in verify.ts#14705
Merged
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Verifier audit findings, each verified against the source:
- ensurePptxMaxSlides passed 'true' into the rels slot instead of
isSlideMax, so the slide{N+1}-must-not-exist assertion never ran -
the verifier could only fail when the deck had FEWER slides than the
max, the inverse of its purpose. Two live regression tests (9681,
11896: no extra blank slides) were neutered by this.
- ensureHtmlElementContents skipped selectors that matched nothing -
all content assertions silently vacuous when the selector is absent
(e.g. jupyter display-error tests pass if error output disappears
entirely). Now asserts the selector matched.
- verifyYamlFile resolved successfully when the yaml file was missing
or empty; now fails loudly before running the predicate.
- ensurePptxRegexMatches MOVED the pptx into its temp dir (destroying
it for any later verifier in the same test); now copies like
withPptxContent does.
Like the previous commit, these assertions were dead until now and may
surface genuine regressions on their first live CI run.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cderv
force-pushed
the
test/verify-vacuous-pass
branch
from
July 17, 2026 18:44
b9b54a6 to
f3ea9c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three shared verifiers in
tests/verify.tspass vacuously — a broken assertion never fails the test:ensureHtmlElementContentsskips its content assertions when the selector matches no element, instead of failing.ensurePptxMaxSlidespassedtruein therelspositional slot, silently disabling the max-slides check entirely.verifyYamlFileskips its predicate when the yaml file is missing or empty.The pptx unzip helper also moved the file instead of copying it, so later verifiers in the same test lost access to it.
These helpers are used across the smoke suite, so the fix lands on its own rather than buried in the larger change that surfaced it.