Revise MANIFEST.in - #1107
Conversation
The previous approach of relying on setuptools-scm's ability to use the `.gitignore` file apparently doesn't work when building sdist distributions using a toolchain that runs inside a Docker environment. This PR revises and tunes the `MANIFEST.in` file to get just the things needed for the sdist file.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the MANIFEST.in file to explicitly define the files and directories to include, graft, prune, and exclude for the source distribution, replacing the previous simple recursive-exclude rules. It also adds a standard Apache 2.0 copyright and license header to the file. There are no review comments to address, and I have no feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request updates the MANIFEST.in file to comprehensively specify which files and directories are included or excluded in the source distribution, replacing the previous minimal configuration. The reviewer raised a valid concern that pruning the tests and third_party directories could break C++ compilation during source distribution installation if CMakeLists.txt unconditionally references them.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the MANIFEST.in file to explicitly define the files and directories included in and excluded from the source distribution. It adds a copyright and license header, includes root build files, metadata, C++ sources, Pybind interfaces, and Python package sources, while pruning development tools, documentation, container configurations, and build artifacts. There are no review comments, so I have no feedback to provide.
1 participant
The previous approach of relying on setuptools-scm's ability to use the
.gitignorefile apparently doesn't work when building sdist distributions using a toolchain that runs inside a Docker environment.This PR revises and tunes the
MANIFEST.infile to get just the things needed for the sdist file.