Repository navigation
snagfactory: recognize 'ufs<num>' as a valid target-device - #5
Merged
Merged
Conversation
BakyarajM
requested review from
aswinm94,
balajiselvanathan,
Gopinath Sekar (g-sekar) and
varada-qcom
September 1, 2026 05:31
BakyarajM
force-pushed
the
UFS-support
branch
from
September 1, 2026 05:38
2b608b5 to
0a9053a
Compare
BakyarajM
changed the title
BakyarajM
force-pushed
the
USB-timeout
branch
from
September 1, 2026 05:47
879d43d to
6c96923
Compare
UFS is LBA-addressable like eMMC, so accept 'ufs' as a target-device value and skip the eraseblk-size requirement for it, same as for 'mmc<num>'. However, U-Boot addresses UFS storage through the "scsi", rather than the "mmc"-specific commands generated by the "gpt", "flash", "mtd-parts" and "emmc-hwpart" tasks. Reject 'ufs' targets for these tasks with a clear configuration error pointing users to the "run" task, which can issue the equivalent raw commands directly (e.g. "oem_run:gpt write scsi <dev> ..."). Signed-off-by: Bakyaraj Moorthy <bmoorthy@qti.qualcomm.com>
BakyarajM
force-pushed
the
UFS-support
branch
from
September 1, 2026 05:48
0a9053a to
43993a7
Compare
Gopinath Sekar (g-sekar)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UFS is LBA-addressable like eMMC, so accept 'ufs' as a target-device value and skip the eraseblk-size requirement for it, same as for 'mmc'.
However, U-Boot addresses UFS storage through the "scsi", rather than the "mmc"-specific commands generated by the "gpt", "flash", "mtd-parts" and "emmc-hwpart" tasks. Reject 'ufs' targets for these tasks with a clear configuration error pointing users to the "run" task, which can issue the equivalent raw commands directly (e.g. "oem_run:gpt write scsi ...").
Signed-off-by: Bakyaraj Moorthy bmoorthy@qti.qualcomm.com