Repository navigation
snagfactory: add configurable USB re-enumeration timeout - #4
Merged
Merged
Conversation
BakyarajM
requested review from
aswinm94,
balajiselvanathan,
Gopinath Sekar (g-sekar) and
varada-qcom
September 1, 2026 05:19
BakyarajM
force-pushed
the
auto-sparse-conversion
branch
2 times, most recently
from
September 1, 2026 05:46
4e20aa6 to
853906b
Compare
After snagrecover downloads U-Boot, snagflash immediately attempts to reconnect over Fastboot. The existing get_usb() retry loop only waits ~9 seconds before giving up, which may be not enough time for previous stage bootloader to exit, handover control to U-Boot, U-Boot to boot and re-enumerate the Fastboot USB gadget. Add an optional "usb-wait-timeout" global parameter to the Snagfactory configuration file, specifying the number of seconds to wait for the board's Fastboot USB device to reappear. This value is forwarded to snagflash's fastboot() entry point and converted into a corresponding number of get_usb() retries, overriding the default when set. Signed-off-by: Bakyaraj Moorthy <bmoorthy@qti.qualcomm.com>
BakyarajM
force-pushed
the
USB-timeout
branch
from
September 1, 2026 05:47
879d43d to
6c96923
Compare
Gopinath Sekar (g-sekar)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After snagrecover downloads U-Boot, snagflash immediately attempts to reconnect over Fastboot. The existing get_usb() retry loop only waits ~9 seconds before giving up, which may be not enough time for previous stage bootloader to exit, handover control to U-Boot, U-Boot to boot and re-enumerate the Fastboot USB gadget.
Add an optional "usb-wait-timeout" global parameter to the Snagfactory configuration file, specifying the number of seconds to wait for the board's Fastboot USB device to reappear. This value is forwarded to snagflash's fastboot() entry point and converted into a corresponding number of get_usb() retries, overriding the default when set.