tests: add pytest-based unit tests - #147
Open
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Open
Conversation
Add pytest unit tests; shell integration checks untouched. - tests/unit/test_utils.py: CalcCRC32 verified against binascii.crc32 (implementation matches standard CRC-32/IEEE reflected), reflect() properties, EnsureDirectoryExists behavior. - tests/unit/test_gen_partition.py: end-to-end coverage of gen_partition via subprocess (the module runs its main logic at import time), covering KB/MB/GB size parsing, GPT attribute bits (bootable/readonly), -m image map overrides, multi-LUN ordering, and error paths. - tests/unit/test_cli.py: qcom-ptool dispatcher (--version, --help, invalid subcommand, dispatch to each legacy script). Signed-off-by: Ali Erdinc Koroglu <ali.koroglu@oss.qualcomm.com>
Ali Erdinc Koroglu (aekoroglu)
requested review from
Dmitry Baryshkov (lumag),
Nicolas Dechesne (ndechesne) and
Viswanath Kraleti (vkraleti)
as code owners
July 24, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pytest unit tests; shell integration checks untouched.