gpt: add qbootctl A/B slot flags as named GPT attributes - #137
gpt: add qbootctl A/B slot flags as named GPT attributes#137Royyan Zahir (royzah) wants to merge 2 commits into
Conversation
9c12f82 to
dd3dde6
Compare
|
Dmitry Baryshkov (@lumag) |
dd3dde6 to
d8c1fe6
Compare
|
Missing the SoB tag |
d8c1fe6 to
7ac1108
Compare
|
Added the Signed-off-by, thanks. |
80b4ce4 to
7ac1108
Compare
7ac1108 to
24b4156
Compare
|
Dmitry Baryshkov (@lumag) rebased on main and completed the named set: |
|
Igor Opaniuk (@igoropaniuk) could you please take a look? |
|
This is doing inside the legacy I have no comments for this particular PR (LGTM), the fundamental question is if we want to keep investing time and prettify existing legacy Btw, it also needs a |
|
Igor Opaniuk (@igoropaniuk) thanks, checksums pushed. only the 31 on legacy vs YAML, fair question, up to you and Dmitry Baryshkov (@lumag). two things worth knowing: this is also a bug fix, not just nicer names. and whatever #134 lands as, the |
74f1775 to
f26dcff
Compare
|
Dmitry Baryshkov (@lumag) done, squashed the checksums into the flags commit. |
f26dcff to
ea15f20
Compare
|
Rebased on main, checksums regenerated on top of the qcs615-ride layout change, checks green locally. Dmitry Baryshkov (@lumag) PTAL |
|
Conflicts in |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Signed-off-by: ivan.trubachev ivan.trubachev@tii.ae
Please get a permission from Ivan to use a full name rather than a login name.
|
Fixed, both trailers now carry his full name. Same tree, message-only change. Dmitry Baryshkov (@lumag) PTAL |
ea15f20 to
9e921d2
Compare
Add active/successful/unbootable partition options (gen_partition --active/--successful/--unbootable) mapping to the qbootctl A/B attribute bits 50/54/55 (gpt-utils.h). ptool builds Attributes from these named flags; no raw attribute value is written. Signed-off-by: Royyan Zahir <royzah@gmail.com>
Add --bootable, --readonly, --priority and --tries-remaining so every attribute bit is reachable by name and --attributes is never required. Named flags take precedence; --attributes keeps working unchanged. Regenerate the integration checksums: the named defaults are emitted for every partition, so each generated partitions.xml gains active, successful and unbootable. The GPT binaries are unchanged. Co-developed-by: Ivan Trubachev <ivan.trubachev@tii.ae> Signed-off-by: Ivan Trubachev <ivan.trubachev@tii.ae> Signed-off-by: Royyan Zahir <royzah@gmail.com>
9e921d2 to
7d087a1
Compare
--attributeswas parsed only into the bootable (bit 2) and readonly (bit 60) flags, so the qbootctl A/B slot attributes were dropped and never reached the GPT.Add
active/successful/unbootableas named partition options (gen_partition--active/--successful/--unbootable), mapping to the qbootctl A/B attribute bits (gpt-utils.h: 50 / 54 / 55). ptool builds the GPT Attributes from these named flags; no raw attribute value is written.