fastrpc-test: remove SoC blacklists and SM8850 exception - #532
Srikanth Muppandam (smuppand) merged 1 commit into
Conversation
Srikanth Muppandam (smuppand)
left a comment
There was a problem hiding this comment.
only_hap_example_failed() now has no callers and still documents the SM8850 exception being removed. Remove the function and obsolete comment in this PR.
|
Hi Srikanth Muppandam (@smuppand), With the upcoming tag to be released for fastrpc recipe : we are enabling gpdsp test support as-well. |
2adfe81 to
d8a040c
Compare
There was a problem hiding this comment.
With these new changes, you have to fix the following code as well.
Runner/utils/lib_fastrpc.sh:151 — artifact discovery validates generic directories, not FastRPC artifacts
-
Issue: FASTRPC_RESOLVED_LIB_SYS_DIR becomes /usr/lib whenever that directory exists. Likewise, the runner checks FASTRPC_RESOLVED_SKEL_BASE,
although the base can exist without either v75 or v68. FASTRPC_RESOLVED_LIB_TEST_DIR is discovered but never required. -
Recommended fix: Resolve and validate the actual required library files, require a non-empty FASTRPC_RESOLVED_SKEL_PATH, and validate the required
test-library artifacts rather than generic directories.
Runner/suites/Multimedia/CDSP/fastrpc_test/fastrpc_test.yaml:11 — YAML still documents removed GPDSP filtering
- Issue: The description says GPDSP domains are skipped on QCS9075/QCS8275/QCS8300/QCS9100, while the PR removes that blacklist.
- Recommended fix: Describe runtime domain and endpoint discovery instead.
Runner/suites/Multimedia/CDSP/fastrpc_test/run.sh:188 — remove unused SOC_MACHINE
- Recommended fix: Remove the assignment.
d8a040c to
283b5cf
Compare
283b5cf to
7dac287
Compare
7dac287 to
f34a642
Compare
Srikanth Muppandam (smuppand)
left a comment
There was a problem hiding this comment.
anankulk Please address the pending comments too
f34a642 to
4528956
Compare
4528956 to
a14fa9c
Compare
a14fa9c to
39a5eeb
Compare
|
anankulk sign-off is missing from the recent patches. |
39a5eeb to
e58bf32
Compare
e58bf32 to
f54abca
Compare
f54abca to
1d79009
Compare
|
anankulk Restore executable mode on run.sh. |
1d79009 to
3f15986
Compare
f8c8786 to
78bf7d4
Compare
50cdb60 to
92164bb
Compare
|
Fixes #586 |
ce97af3 to
de1d4be
Compare
Re-enable fastrpc_test for glymur-crd, iq-x7181-evk, rb1-core-kit, and shikra-evk. Tests pass on latest meta-qcom tip except SKIP on glymur and rb1, which will be fixed after merge of referenced PR. Previous failures were random and non-reproducible per fastrpc team confirmation. Ref: qualcomm-linux/qcom-linux-testkit#532 Signed-off-by: Anil Yadav <anilyada@qti.qualcomm.com>
de1d4be to
9e57bc6
Compare
Srikanth Muppandam (smuppand)
left a comment
There was a problem hiding this comment.
This PR looks ready to merge. Once the latest comment is addressed, we should be good to go.
| } | ||
|
|
||
| if ! parse_args "$@"; then | ||
| echo "$TESTNAME : FAIL" >"$RESULT_FILE" |
There was a problem hiding this comment.
The updated suite still writes results directly through repeated echo "$TESTNAME : ..." paths and maintains separate PASS/FAIL counters instead of using test_result_init, test_result_record, and test_result_finish.
Because the result file is not cleared at startup, an interrupted or unexpectedly terminated run can leave a previous PASS result for send-to-lava.sh to consume. The many newly added early exits also duplicate finalization behavior.
Initialize the result state immediately after defining TESTNAME and RES_FILE, record invocation outcomes through test_result_record, and route every terminal PASS/FAIL/SKIP path through test_result_finish.
There was a problem hiding this comment.
Acknowledged.
- test_result_init "$TESTNAME" "$RESULT_FILE" called immediately after RESULT_FILE is defined — clears any stale result file at startup
- All per-invocation outcomes routed through test_result_record "PASS"/"FAIL" — separate PASS_COUNT/TOTAL_COUNT variables removed
- Every terminal path (early validation, healthcheck failures, domain selection, final result) routed through test_result_finish
- Validated on QCS9075: 9 invocations, 9 passed
…dation Remove hardcoded SoC-based domain filtering and per-SoC PD support maps. Use fastrpc-healthcheck as the primary capability source for domain online state and signed/unsigned PD support per domain. An installed healthcheck that fails, times out, or produces malformed output fails the suite; runtime fallback applies only when the tool is absent, using remoteproc/endpoint discovery for domains and a conservative static protocol map for PD support. - Log capability_source, domain_source, and pd_source in [FASTRPC-POLICY] - Automatic mode skips domains missing runtime readiness, endpoint, or library; explicit selection fails with a diagnostic message - Strict healthcheck parser with field validation, duplicate detection, GPDSP0/GPDSP1 canonicalization, and atomic TSV write - Identity-based remoteproc-to-domain mapping; FASTRPC_DOMAIN/NAME force single-domain independently of --domain-mode - Add --healthcheck-timeout (default 15s); enforce finite --timeout (120s) - Validate option arguments, FASTRPC_UNSIGNED_PD, and ALLOW_BIN_FASTRPC - Discover DSP skeletons from actual .so presence, not hardcoded ABI names - Capture kernel evidence once after the run matrix on any failure Signed-off-by: Anand Kulkarni <anankulk@qti.qualcomm.com>
9e57bc6 to
1be043c
Compare
Srikanth Muppandam (smuppand)
left a comment
There was a problem hiding this comment.
LGTM
304e039
into
qualcomm-linux:main
Summary
Remove hardcoded SoC-based domain filtering and per-SoC PD support maps.
Previously blacklisted platforms (e.g. Glymur CRD) were fully skipped
regardless of actual hardware capability. This PR replaces that approach
with runtime discovery driven by
fastrpc-healthcheck.Changes
fastrpc-healthcheckas the primary capability source for domainonline state and signed/unsigned PD support per domain
output fails the suite; runtime fallback applies only when tool is absent
/dev/fastrpc-<domain>[-secure]endpoint presence for domain discovery when healthcheck is unavailable
(ADSP/MDSP/SDSP: signed only; CDSP/CDSP1/GDSP0/GDSP1: signed + unsigned)
domain_sourceandpd_sourcefields to[FASTRPC-POLICY]log linelibrary; explicit selection fails with a diagnostic message
GPDSP0/GPDSP1 canonicalization
guessing;
FASTRPC_DOMAIN/FASTRPC_DOMAIN_NAMEforce single-domainindependently of
--domain-mode--healthcheck-timeoutparameter (default 15s)--timeoutwith explicit default of 120sFASTRPC_UNSIGNED_PDenvironment variable.sopresence, not hardcoded ABI namesValidation