Skip to content

UPSTREAM: arm64: dts: qcom: talos: Fix cpu6 1094.4MHz OPP frequency typo - #908

Open
imrashai wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
imrashai:talos-cpu6-opp-fix
Open

UPSTREAM: arm64: dts: qcom: talos: Fix cpu6 1094.4MHz OPP frequency typo#908
imrashai wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
imrashai:talos-cpu6-opp-fix

Conversation

@imrashai

@imrashai imrashai commented Aug 6, 2026

Copy link
Copy Markdown

opp-1094400000 in cpu6_opp_table has a typo in opp-hz, missing a trailing zero. Fix it to resolve the following OPP update failures:

cpu cpu6: Voltage update failed freq=1094400
cpu cpu6: failed to update OPP for freq=1094400

Fixes: 44562f5 ("arm64: dts: qcom: qcs615: Add OSM l3 interconnect provider node and CPU OPP tables to scale DDR/L3")

Reviewed-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com
Link: https://lore.kernel.org/r/20260730-talos-cpu6-opp-fix-v1-1-f4886fdff13f@oss.qualcomm.com

CRs-Fixed: 4617936

opp-1094400000 in cpu6_opp_table has a typo in opp-hz, missing a trailing
zero. Fix it to resolve the following OPP update failures:

cpu cpu6: Voltage update failed freq=1094400
cpu cpu6: failed to update OPP for freq=1094400

Fixes: 44562f5 ("arm64: dts: qcom: qcs615: Add OSM l3 interconnect provider node and CPU OPP tables to scale DDR/L3")
Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260730-talos-cpu6-opp-fix-v1-1-f4886fdff13f@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4617936 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4617936
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #908 — validate-patch

PR: #908

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — properly formatted in Link: trailer
  2. Lore link matches PR commits: Yes — commit message body, diff, and metadata are identical to lore patch
  3. Upstream patch status: ✅ ACKed — merged as f2eb18c66b98fbfcbab4daef42c04f4becba7d79 by Bjorn Andersson on 2026-07-30
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #908 - UPSTREAM: arm64: dts: qcom: talos: Fix cpu6 1094.4MHz OPP frequency typo
Upstream commit: https://lore.kernel.org/r/20260730-talos-cpu6-opp-fix-v1-1-f4886fdff13f@oss.qualcomm.com
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream UPSTREAM: prefix added; rest identical
Body preserves rationale Identical - describes typo and OPP failure
Fixes tag present/correct Matches lore: Fixes: 44562f591890
Authorship preserved From: matches lore author (Imran Shaik)
Backport note (if applicable) N/A Not a backport - merged directly upstream

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos.dtsi Identical - fixes typo 1094400001094400000

Issues

None found. The PR commit is a faithful representation of the upstream patch.

Verdict

Merge as-is. This is a clean upstream commit with proper attribution, correct Fixes tag, and maintainer sign-off.

Final Summary

  1. Lore link present: Yes — properly formatted in Link: trailer
  2. Lore link matches PR commits: Yes — commit message body, diff, and metadata are identical to lore patch
  3. Upstream patch status: ✅ ACKed — merged as f2eb18c66b98fbfcbab4daef42c04f4becba7d79 by Bjorn Andersson on 2026-07-30
  4. PR present in qcom-next/topics: Yes — exact patch-id match found at f2eb18c66b98fbfcbab4daef42c04f4becba7d79 in topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] UPSTREAM: arm64: dts: qcom: talos: Fix cpu6 1094.4MHz OPP missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at f2eb18c66b98fbfcbab4daef42c04f4becba7d79 present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #908 — checker-log-analyzer

PR: #908
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31077164289

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 warning: Unknown commit id in Fixes tag
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Passed
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Passed
tag-check Passed - valid UPSTREAM: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #908 - UPSTREAM: arm64: dts: qcom: talos: Fix cpu6 1094.4MHz OPP frequency typo
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31077164289

Checker Result Summary
checkpatch ⚠️ 1 warning: Unknown commit id in Fixes tag
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Passed
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Passed
tag-check Passed - valid UPSTREAM: prefix

⚠️ checkpatch

Root cause: The Fixes: tag references commit 44562f591890 which is not present in the CI runner's kernel tree at the time of the check.

Failure details:

WARNING: Unknown commit id '44562f591890', maybe rebased or not pulled?
#13: 
Fixes: 44562f591890 ("arm64: dts: qcom: qcs615: Add OSM l3 interconnect provider node and CPU OPP tables to scale DDR/L3")

a4e5394e8940a86bb45af4bc52037e44d496ec7d total: 0 errors, 1 warnings, 0 checks, 8 lines checked

Analysis: This is a false positive — the warning indicates that checkpatch.pl cannot verify the commit SHA in the Fixes: tag because the referenced commit is not reachable from the CI runner's current tree state. This commonly occurs when:

  • The fixed commit exists in a different branch or topic tree
  • The CI runner's tree is not fully synced with all upstream/topic branches
  • The commit is from an older kernel version

The Fixes: tag format itself is correct (12-char SHA + subject in quotes), and the commit does exist in the kernel history (as evidenced by the integration presence report showing this patch is already present in topics).

Fix: No action required. This is a known limitation of checkpatch.pl when run in CI environments with partial tree history. The Fixes: tag is correctly formatted and references a valid upstream commit.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 8635749eab9a..a4e5394e8940

✅ All Other Checkers

  • dt-binding-check: Skipped (no changes in Documentation/devicetree/bindings)
  • dtb-check: Passed (no new DTB validation errors)
  • sparse-check: Skipped (no C/H file changes)
  • check-uapi-headers: Skipped (no UAPI changes)
  • check-patch-compliance: Passed (valid UPSTREAM: prefix, valid Link: tag, content matches upstream)
  • tag-check: Passed (commit subject starts with valid UPSTREAM: prefix)

Verdict

Ready to merge. The single checkpatch warning is a false positive caused by the CI environment's incomplete tree history. The patch is correctly formatted, has proper upstream attribution (UPSTREAM: prefix, Link: tag, Fixes: tag), and all substantive checkers passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants