Skip to content

QCLINUX: arm64: dts: qcom: shikra: Install camx DTBO overlays - #902

Open
michael-jihan-qcom wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
michael-jihan-qcom:shikra_jihan_camera_dtsi_merge
Open

QCLINUX: arm64: dts: qcom: shikra: Install camx DTBO overlays#902
michael-jihan-qcom wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
michael-jihan-qcom:shikra_jihan_camera_dtsi_merge

Conversation

@michael-jihan-qcom

Copy link
Copy Markdown

Add Makefile entries to build and install camera (camx) DTBO overlays for Shikra CQS EVK and IQS EVK board variants.

Each composite DTB bundles the respective base platform DTB with the camx overlay, and registers both the merged .dtb and standalone .dtbo.

CRs-Fixed: 4630873

Add Makefile entries to build and install camera (camx) DTBO overlays
for Shikra CQS EVK and IQS EVK board variants.

Each composite DTB bundles the respective base platform DTB with the
camx overlay, and registers both the merged .dtb and standalone .dtbo.

Signed-off-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4630873 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4630873

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #902 — validate-patch

PR: #902

Verdict Issues Detailed Report
1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #902 - QCLINUX: arm64: dts: qcom: shikra: Install camx DTBO overlays
Upstream commit: N/A (vendor-only change)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of Makefile entries for camx DTBO overlays
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Internal Qualcomm author appropriate for vendor commit
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds camx DTBO build entries for shikra-cqs-evk and shikra-iqs-evk
arch/arm64/boot/dts/qcom/shikra-camera.dtsi New camera device tree include (1191 lines)
arch/arm64/boot/dts/qcom/shikra-cqs-evk-camx.dtso New DTBO overlay for CQS EVK variant
arch/arm64/boot/dts/qcom/shikra-iqs-evk-camx.dtso New DTBO overlay for IQS EVK variant

Issues

  • Integration presence failure: Commit is missing from both qcom-next and kernel topic branches. Vendor commits should be present in the integration tree before PR merge.

Verdict

Do not merge. The commit is not present in qcom-next or topics branches. Vendor-only commits must be integrated into the appropriate topic branch first.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: shikra: Install camx DTBO overlays missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #902 — checker-log-analyzer

PR: #902
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30986385986

Checker Result Summary
Checker Result Summary
checkpatch 26 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check 8 reg_format errors, multiple avoid_default_addr_size warnings
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No relevant files changed
check-patch-compliance QCLINUX: prefix not in allowed list (known limitation)
tag-check Subject has valid QCLINUX: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #902 - QCLINUX: arm64: dts: qcom: shikra: Install camx DTBO overlays
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30986385986
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 26 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check 8 reg_format errors, multiple avoid_default_addr_size warnings
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No relevant files changed
check-patch-compliance QCLINUX: prefix not in allowed list (known limitation)
tag-check Subject has valid QCLINUX: prefix

❌ checkpatch

Root cause: 26 undocumented DT compatible strings in shikra-camera.dtsi

Failure details:

WARNING: DT compatible string "qcom,csiphy-v2.0.0" appears un-documented
WARNING: DT compatible string "qcom,csid530" appears un-documented (×2)
WARNING: DT compatible string "qcom,tfe530" appears un-documented (×2)
WARNING: DT compatible string "qcom,cam-cdm-intf" appears un-documented
WARNING: DT compatible string "qcom,cam-isp" appears un-documented
WARNING: DT compatible string "qcom,cam-ope" appears un-documented
WARNING: DT compatible string "qcom,cam-req-mgr" appears un-documented
WARNING: DT compatible string "qcom,msm-cam-smmu" appears un-documented
WARNING: DT compatible string "qcom,msm-cam-smmu-cb" appears un-documented (×4)
WARNING: DT compatible string "qcom,cam-sync" appears un-documented
WARNING: DT compatible string "qcom,camera_shikra" appears un-documented

Fix: Add DT binding YAML files for each undocumented compatible string to Documentation/devicetree/bindings/. Each binding must document the compatible string, required properties, and provide an example.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 8635749eab9a..d5ce8b1e8f04

❌ dtb-check

Root cause: reg property cell counts don't match parent #address-cells/#size-cells in overlay fragment nodes

Failure details:

shikra-camera.dtsi:13: Warning (reg_format): qcom,cam-cpas@5c11000:reg: 
  property has invalid length (32 bytes) (#address-cells == 2, #size-cells == 1)
shikra-camera.dtsi:233: Warning (reg_format): qcom,cci0@5c1b000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
shikra-camera.dtsi:337: Warning (reg_format): qcom,cpas-cdm0@5c23000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
shikra-camera.dtsi:376: Warning (reg_format): qcom,ope-cdm0@5c42000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
shikra-camera.dtsi:503: Warning (reg_format): qcom,csiphy0@5c52000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
shikra-camera.dtsi:557: Warning (reg_format): qcom,csiphy1@5c53000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
shikra-camera.dtsi:669: Warning (reg_format): qcom,tfe0@5c6e000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
shikra-camera.dtsi:776: Warning (reg_format): qcom,tfe1@5c75000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)

Additional warnings: avoid_default_addr_size (nodes relying on default #address-cells/#size-cells)
Additional warnings: interrupts_property (missing interrupt-parent)

Fix: The reg properties in the overlay fragment nodes have incorrect cell counts. The parent expects #address-cells = 2, #size-cells = 1 (3 cells total = 12 bytes), but:

  • qcom,cam-cpas@5c11000 has 32 bytes (8 cells) → should be 12 bytes (3 cells)
  • All other nodes have 16 bytes (4 cells) → should be 12 bytes (3 cells)

Fix each reg property to match the expected format:

reg = <0x0 0x5c11000 0x1000>;  // 3 cells: address-high address-low size

Also add explicit #address-cells and #size-cells to parent nodes, and add interrupt-parent properties where interrupts are used.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqs-evk-camx.dtbo
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-iqs-evk-camx.dtbo

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:)

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: shikra: Install camx DTBO overlays...
Commit summary does not start with a required prefix

Fix: This is a known checker limitation for vendor-only commits. The check-patch-compliance checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). Vendor-internal prefixes like QCLINUX: and PENDING: always fail this check.

Options:

  1. If this patch will be posted upstream, change prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL
  2. If this is vendor-only code with no upstream equivalent, the checker will always fail — this is expected and can be ignored

Note: The commit does have a valid subject-line prefix tag (QCLINUX:), so it passes the mandatory tag-check for non-qcom-next branches.


✅ tag-check

Status: PASS

Analysis: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so subject-line prefix tags are mandatory. The commit subject starts with QCLINUX:, which is a valid prefix. Tag-check passes.


Verdict

3 blockers must be fixed before merge:

  1. checkpatch (26 warnings): Add DT binding YAML files for all 13 undocumented compatible strings in Documentation/devicetree/bindings/
  2. dtb-check (8 reg_format errors): Fix reg property cell counts in shikra-camera.dtsi to match parent #address-cells/#size-cells (3 cells = 12 bytes per reg entry)
  3. check-patch-compliance (QCLINUX: prefix): Known limitation — if this is vendor-only code, this failure is expected and can be ignored; if posting upstream, change to FROMLIST: + add Link: trailer

Priority: Fix dtb-check reg_format errors first (runtime correctness), then add DT bindings (documentation completeness). The check-patch-compliance failure is a known checker limitation for vendor-only commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants