Skip to content

QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1 - #815

Open
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:cam1_imx_kodiak_qli2.0
Open

QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1#815
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:cam1_imx_kodiak_qli2.0

Conversation

@mvadlama-lab

@mvadlama-lab mvadlama-lab commented Jul 9, 2026

Copy link
Copy Markdown

CAM1 port is currently enabled for OV9282.This change adds DTSI configuration for IMX577 so that CAM1 can also support IMX577 sensor on the hardware platform of QCM6490 Dev.

CRs-Fixed: 4633982

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4243195 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4243195
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #815 — validate-patch

PR: #815

Verdict Issues Detailed Report
1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #815 — QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS (vendor-only)

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream source
Body preserves rationale Clear description of CAM1 IMX577 sensor support
Fixes tag present/correct N/A New feature addition; no Fixes tag required
Authorship preserved Author and Signed-off-by match
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi Adds eeprom_cam1 and qcom,cam-sensor12 nodes for IMX577 (78 lines)

Issues

  • Minor: Missing space after period in commit body: "OV9282.This" should be "OV9282. This"

Verdict

Merge as-is. This is a vendor-specific device tree addition for IMX577 camera sensor support on QCM6490 RB3 Gen2. The commit message clearly describes the change, authorship is correct, and the diff adds the expected EEPROM and sensor configuration nodes. The minor spacing issue in the commit message does not affect functionality.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #815 — checker-log-analyzer

PR: #815
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29011270950

Checker Result Summary
Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check New schema validation failures for qcom,eeprom and qcom,cam-sensor
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check Subject has valid prefix (branch is qcom-6.18.y, not qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #815 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29011270950

Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check New schema validation failures for qcom,eeprom and qcom,cam-sensor
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check Subject has valid prefix (branch is qcom-6.18.y, not qcom-next)

❌ checkpatch

Root cause: Two undocumented DT compatible strings used in the new DTSI file.

Failure details:

WARNING: DT compatible string "qcom,eeprom" appears un-documented
#26: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:180:
+		compatible = "qcom,eeprom";

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented
#64: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:218:
+		compatible = "qcom,cam-sensor";

318e29e1bb29 total: 0 errors, 2 warnings, 0 checks, 84 lines checked

Fix: Add DT binding YAML files for these compatible strings:

  1. Create Documentation/devicetree/bindings/media/qcom,eeprom.yaml
  2. Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml

Or, if these are vendor-specific camera subsystem nodes not intended for upstream, document them in a vendor-specific binding file.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git cf2725e2d166..318e29e1bb29

❌ dtb-check

Root cause: The new DTS nodes use qcom,eeprom and qcom,cam-sensor compatible strings that have no schema bindings, causing validation failures.

Failure details:

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb:
  /soc@0/qcom,cci0/qcom,eeprom1: failed to match any schema with compatible: ['qcom,eeprom']

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb:
  /soc@0/qcom,cci0/qcom,cam-sensor12: failed to match any schema with compatible: ['qcom,cam-sensor']

qcom,eeprom1 (qcom,eeprom): gpio-req-tbl-label: b'CAMIF_MCLK1 CAM_RESET1 CAM_CUSTOM1 '
  is not of type 'object', 'integer', 'array', 'boolean', 'null'

qcom,cam-sensor12 (qcom,cam-sensor): gpio-req-tbl-label: b'CAMIF_MCLK1 CAM_RESET1 CAM_CUSTOM1 '
  is not of type 'object', 'integer', 'array', 'boolean', 'null'

qcom,cci0 (qcom,cci): qcom,eeprom1: 'ranges' is a required property
qcom,cci0 (qcom,cci): qcom,cam-sensor12: 'ranges' is a required property

Fix:

  1. Add DT binding schema files for qcom,eeprom and qcom,cam-sensor compatible strings
  2. Define the gpio-req-tbl-label property type correctly in the binding (should be an array of strings, not a space-separated string)
  3. Add ranges property to the parent qcom,cci0 node if required by the CCI binding

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb

❌ check-patch-compliance

Root cause: The commit uses QCLINUX: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Commit summary does not start with a required prefix

Fix: This is a known limitation of the check-patch-compliance checker. The QCLINUX: prefix is a valid vendor-internal prefix used in the Qualcomm Linux tree for vendor-only changes that have no upstream equivalent. However, the checker only accepts upstream-linkable prefixes.

Options:

  1. If this change is vendor-only (not intended for upstream): Accept that this checker will always fail. This is expected behavior for QCLINUX: commits.
  2. If this change could be posted upstream: Change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org mailing list thread.

For vendor-only DTS changes like camera sensor configurations specific to Qualcomm development boards, option 1 is appropriate — the checker failure is expected and can be ignored.


Verdict

3 blockers to fix before merge:

  1. checkpatch warnings — Add DT binding YAML files for qcom,eeprom and qcom,cam-sensor, or document why these vendor-specific compatibles don't need upstream bindings.

  2. dtb-check failures — The new nodes fail schema validation because:

    • No binding exists for qcom,eeprom and qcom,cam-sensor
    • Property types are incorrect (gpio-req-tbl-label should be an array, not a string)
    • Missing ranges property in parent CCI node
  3. check-patch-compliance failure — This is a known limitation for QCLINUX: prefixed commits. If this is genuinely a vendor-only change, this failure can be accepted as-is. If the change should be upstreamed, change the prefix to FROMLIST: and add a Link: tag.

Recommendation: Fix items 1 and 2 (add bindings and fix property types). Item 3 can be accepted if this is vendor-only work.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ◻️ ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ◻️ ◻️ ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ◻️ ◻️ ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Ethernet ◻️ ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip
Freq_Scaling ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
IPA ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
OpenCV ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ◻️ ◻️ ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail
RMNET ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
USBHost ◻️ ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ◻️ ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ◻️ ◻️ ❌ Fail ⚠️ skip ✅ Pass ✅ Pass ✅ Pass
adsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
cdsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ◻️ ◻️ ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass
hotplug ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
rngtest ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ◻️ ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail
watchdog ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

rgltr-load-current = <120000>;
gpio-no-mux = <0>;
pinctrl-names = "cam_default", "cam_suspend";
pinctrl-0 = <&cam_sensor_mclk1_active

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please align it properly

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gpio-custom1 = <2>;
gpio-req-tbl-num = <0 1 2>;
gpio-req-tbl-flags = <1 0 0>;
gpio-req-tbl-label = "CAMIF_MCLK1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

rgltr-load-current = <120000>;
gpio-no-mux = <0>;
pinctrl-names = "cam_default", "cam_suspend";
pinctrl-0 = <&cam_sensor_mclk1_active

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please align it properly

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gpio-custom1 = <2>;
gpio-req-tbl-num = <0 1 2>;
gpio-req-tbl-flags = <1 0 0>;
gpio-req-tbl-label = "CAMIF_MCLK1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CAM1 port is currently enabled for OV9282.This change adds
DTSI configuration for IMX577 so that CAM1 can also support
IMX577 sensor on the hardware platform of QCM6490 Dev.

Signed-off-by: Vadlamani Manjusha <mvadlama@qti.qualcomm.com>
@mvadlama-lab
mvadlama-lab force-pushed the cam1_imx_kodiak_qli2.0 branch from 318e29e to 2b8ed92 Compare August 5, 2026 10:03
@qcomlnxci
qcomlnxci requested a review from a team August 5, 2026 10:05
@qlijarvis

Copy link
Copy Markdown

PR #815 — validate-patch

PR: #815

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #815 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Upstream commit: N/A (vendor-only commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit; no upstream source
Body preserves rationale Clear description of CAM1 IMX577 sensor support
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Author: Vadlamani Manjusha; Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi Adds 78 lines: eeprom_cam1 and qcom,cam-sensor12 nodes for IMX577

Issues

  • Integration presence: Commit shows only partial evidence in qcom-next/topics. The integration_presence_report indicates "partial - subject or partial tree evidence found, but full change was not verified". This suggests the commit may exist in a similar form but the exact diff was not confirmed in the integration branch.

Verdict

This is a vendor-only (QCLINUX:) commit adding IMX577 camera sensor support to QCS6490 RB3Gen2. The commit message is clear, authorship is correct, and the diff adds appropriate device tree nodes. However, the integration presence check shows only partial evidence in qcom-next/topics, which warrants verification that the change is properly integrated or that this is an intentional new addition not yet in the integration branch.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Partial — 1/1 commit(s) only have partial integration evidence (subject or partial tree match found, but full change not verified)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #815 — checker-log-analyzer

PR: #815
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30996020572

Checker Result Summary
Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check Missing bindings for qcom,eeprom and qcom,cam-sensor
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX prefix not accepted (known limitation)
tag-check Valid QCLINUX prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #815 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30996020572
Target Branch: qcom-6.18.y

Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check Missing bindings for qcom,eeprom and qcom,cam-sensor
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX prefix not accepted (known limitation)
tag-check Valid QCLINUX prefix present

❌ checkpatch

Root cause: Two vendor-specific DT compatible strings lack documentation in vendor-prefixes.yaml.

Failure details:

WARNING: DT compatible string "qcom,eeprom" appears un-documented
#26: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:180:
+		compatible = "qcom,eeprom";

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented
#64: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:218:
+		compatible = "qcom,cam-sensor";

Fix: Add DT binding YAML files for these compatible strings:

  1. Create Documentation/devicetree/bindings/media/qcom,eeprom.yaml
  2. Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml

Alternatively, if these are vendor-internal camera subsystem nodes not intended for upstream, document them in a vendor-specific binding or suppress the warning by adding them to an existing Qualcomm camera binding.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 8635749eab9a..2b8ed92c18b5

❌ dtb-check

Root cause: The newly added DTS nodes reference compatible strings (qcom,eeprom, qcom,cam-sensor) that have no corresponding DT binding schema, causing validation failures.

Failure details:

arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb: /soc@0/qcom,cci0/qcom,cam-sensor12: 
  failed to match any schema with compatible: ['qcom,cam-sensor']

arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb: /soc@0/qcom,cci0/qcom,eeprom1: 
  failed to match any schema with compatible: ['qcom,eeprom']

/opt/.../qcs5430-fps-camx.dtb: qcom,cci0 (qcom,cci): qcom,cam-sensor12: 
  'ranges' is a required property

/opt/.../qcs5430-fps-camx.dtb: qcom,cci0 (qcom,cci): qcom,eeprom1: 
  'ranges' is a required property

qcom,cam-sensor12 (qcom,cam-sensor): gpio-req-tbl-label: 
  b'CAMIF_MCLK1^@CAM_RESET1^@CAM_CUSTOM1^@' is not of type 'object', 'integer', 'array', 'boolean', 'null'

The errors appear in multiple DTB files (qcs5430-fps-camx.dtb, qcs6490-rb3gen2-vision-mezzanine-camx.dtb) that include the modified qcs6490-rb3gen2-camera-sensor.dtsi.

Fix:

  1. Primary fix: Add DT binding YAML schemas for qcom,eeprom and qcom,cam-sensor that declare:

    • All properties used in the DTS nodes (gpio-, regulator-, power-domains, etc.)
    • Whether ranges is required (likely not for leaf camera sensor nodes)
    • Proper type definitions for gpio-req-tbl-label (likely a string array)
  2. Alternative: If these are vendor-internal camera subsystem nodes not intended for upstream, the dtb-check failures are expected. Consider adding these compatible strings to a vendor-specific binding or documenting them in an internal schema.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Commit summary does not start with a required prefix

Fix: This is a known limitation of the check-patch-compliance checker. The checker enforces upstream-linkable prefixes only and does not accept vendor-internal prefixes like QCLINUX: or PENDING:.

Options:

  1. If this change is vendor-only with no upstream equivalent: Accept that check-patch-compliance will always fail for this commit. The QCLINUX: prefix is correct for vendor-internal changes.
  2. If this change has been or will be posted upstream: Change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL.

For vendor-only camera subsystem changes like this one, option 1 is appropriate — the checker failure is expected and does not indicate a patch defect.


Verdict

3 blockers to address before merge:

  1. checkpatch warnings — Add DT binding documentation for qcom,eeprom and qcom,cam-sensor, or document why these vendor-internal compatible strings are acceptable without upstream bindings.

  2. dtb-check failures — Add proper DT binding YAML schemas that declare all properties used by the camera sensor nodes, or accept that vendor-internal camera nodes will fail validation until bindings are added.

  3. check-patch-compliance failure — This is a known limitation for QCLINUX:-prefixed commits. If this is a vendor-only change, the failure is expected and can be accepted. If the change will be upstreamed, change the prefix to FROMLIST: and add a Link: trailer.

Recommendation: If this is a vendor-internal camera subsystem change not intended for upstream, the check-patch-compliance failure is acceptable. The checkpatch and dtb-check failures should be addressed by adding vendor-specific DT binding documentation for the camera subsystem nodes.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ◻️
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Ethernet ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants