Skip to content

FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SM… - #1154

Merged
Salendarsingh Gaud (sgaud-quic) merged 2 commits into
qualcomm-linux:qcom-6.18.yfrom
Komal-Bajaj:shikra-el2
Oct 1, 2026
Merged

Salendarsingh Gaud (sgaud-quic) merged 2 commits into
qualcomm-linux:qcom-6.18.yfrom
Komal-Bajaj:shikra-el2

Conversation

@Komal-Bajaj

@Komal-Bajaj Komal Bajaj (Komal-Bajaj) commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

…MU mappings

Shikra boards currently boot Linux under a hypervisor, where the remote processor firmware IOMMU streams are managed by the hypervisor. When booting Linux directly at EL2 without the hypervisor, the IOMMU is instead managed by the consumer of this DeviceTree, so the firmware streams for each remote processor need to be described explicitly.

Add an EL2-specific DT overlay and apply it to all Shikra EVK variants devices to produce an -el2.dtb alongside the "normal" dtb.

Link: https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
Co-developed-by: Bibek Kumar Patro bibek.patro@oss.qualcomm.com

CRs-Fixed: 4683920

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1154 — validate-patch

PR: #1154

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
  2. Lore link matches PR commits: No — PR contains a typo (shikra-iqm-evk-el2.dtb vs shikra-iqs-evk-el2.dtb) that differs from the lore patch
  3. Upstream patch status: In review — Reviewed-by from Qualcomm maintainer Abel Vesa on 2026-09-21; not yet merged to maintainer tree or mainline
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1154 — FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings
Upstream commit: https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ✅ Subject correctly prefixed with FROMLIST:
Body preserves rationale ✅ Commit body identical to lore patch
Fixes tag present/correct N/A No Fixes tag in upstream patch
Authorship preserved ✅ From: matches lore author; FROMLIST: prefix correct
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile:369 ❌ Typo in dtb target name: PR has shikra-iqm-evk-el2.dtb but should be shikra-iqs-evk-el2.dtb (iqm vs iqs)
arch/arm64/boot/dts/qcom/Makefile:369 ⚠️ Context mismatch: PR applies at line 369, lore at line 359 (10-line offset due to tree differences)
arch/arm64/boot/dts/qcom/shikra-el2.dtso ✅ New file content identical to lore patch

Issues

Critical Issue — Typo in Makefile Target Name

The PR contains a typo in the Makefile that differs from the upstream lore patch:

# PR patch (WRONG):
+dtb-$(CONFIG_ARCH_QCOM)	+= shikra-iqm-evk-el2.dtb
                                          ^^^

# Lore patch (CORRECT):
+dtb-$(CONFIG_ARCH_QCOM)	+= shikra-iqs-evk-el2.dtb
                                          ^^^

The PR incorrectly uses shikra-iqm-evk-el2.dtb instead of shikra-iqs-evk-el2.dtb. This is inconsistent with:

  1. The upstream lore patch (which uses iqs)
  2. The base dtb name shikra-iqs-evk.dtb referenced in the same line
  3. The dtbs variable name shikra-iqs-evk-el2-dtbs defined two lines above

This typo will cause the build system to generate a misnamed dtb file that doesn't match the intended board variant.

Context Offset (Non-blocking)

The Makefile hunk applies at line 369 in the PR tree but line 359 in the lore patch's base tree. This 10-line offset is due to tree differences and is expected for a FROMLIST: patch being applied to a vendor tree that has diverged from mainline. The actual code changes are identical aside from the typo.

Upstream Patch Status

Community Verdict: ✅ Reviewed — Abel Vesa (Qualcomm maintainer) provided Reviewed-by: on 2026-09-21

The lore thread shows a Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com> tag from a Qualcomm maintainer on September 21, 2026. This is a positive signal indicating the patch has been reviewed and is likely to be accepted, though it has not yet been merged into a maintainer tree or mainline as of the evidence available.

Integration Presence

Per integration_presence_report.md:

  • qcom-next: Missing — no subject, patch-id, or full tree-content match found
  • topics: Partial — subject or partial tree evidence found, but full change was not verified
  • Overall: PARTIAL (1/1 commits have only partial integration evidence)

The patch is not yet fully integrated into qcom-next or the kernel topic branches. The "partial" status suggests some related changes may exist, but the exact commit from this PR has not landed.

Verdict

❌ FAIL — The PR must be corrected before merging.

Required Fix:

Change line in arch/arm64/boot/dts/qcom/Makefile:384:

-dtb-$(CONFIG_ARCH_QCOM)	+= shikra-iqm-evk-el2.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= shikra-iqs-evk-el2.dtb

This typo breaks the correspondence with the upstream lore patch and will produce an incorrectly named dtb artifact. Once fixed, the patch will faithfully represent the upstream submission.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
  2. Lore link matches PR commits: No — PR contains a typo (shikra-iqm-evk-el2.dtb vs shikra-iqs-evk-el2.dtb) that differs from the lore patch
  3. Upstream patch status: In review — Reviewed-by from Qualcomm maintainer Abel Vesa on 2026-09-21; not yet merged to maintainer tree or mainline
  4. PR present in qcom-next/topics: Partial — 1/1 commit has only partial integration evidence; not fully present in qcom-next or topics

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1154 — checker-log-analyzer

PR: #1154
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35584276227

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Content mismatch with upstream link
tag-check ✅ Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1154 - FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35584276227

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Content mismatch with upstream link
tag-check ✅ Subject has valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The patch content differs from the upstream lore.kernel.org patch — there is a typo in arch/arm64/boot/dts/qcom/Makefile:384

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings
Change is different from the one mentioned in Link

The checker compared the PR patch against the upstream patch at:
Link: https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com

Analysis:

In arch/arm64/boot/dts/qcom/Makefile at line 384, the patch contains:

+shikra-iqs-evk-el2-dtbs	:= shikra-iqs-evk.dtb shikra-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM)	+= shikra-iqm-evk-el2.dtb

The variable name is shikra-iqs-evk-el2-dtbs (with iqs), but the dtb target being added is shikra-iqm-evk-el2.dtb (with iqm). This is a typo — it should be shikra-iqs-evk-el2.dtb to match the variable name.

This typo is not present in the upstream patch, which is why the content-mismatch check failed.

Fix:

# Edit the Makefile
git rebase -i f7c103b5e1b3   # mark commit ded5601e5d43 as 'edit'

# Fix line 384 in arch/arm64/boot/dts/qcom/Makefile
# Change:
#   dtb-$(CONFIG_ARCH_QCOM)	+= shikra-iqm-evk-el2.dtb
# To:
#   dtb-$(CONFIG_ARCH_QCOM)	+= shikra-iqs-evk-el2.dtb

git add arch/arm64/boot/dts/qcom/Makefile
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com -o /tmp/upstream
git format-patch -1 ded5601e5d43 --stdout > /tmp/pr.patch
diff <(grep '^+' /tmp/upstream/*.mbx | grep -v '^+++') <(grep '^+' /tmp/pr.patch | grep -v '^+++')

Verdict

1 blocker must be fixed before merge: Fix the typo in arch/arm64/boot/dts/qcom/Makefile line 384 — change shikra-iqm-evk-el2.dtb to shikra-iqs-evk-el2.dtb to match the upstream patch and the variable name.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1154

PR: #1154
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35585809842

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'arch/arm64/boot/dts/qcom/shikra-iqm-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:384 Yes Typo in dtb target name: variable is shikra-iqs-evk-el2-dtbs but target is shikra-iqm-evk-el2.dtb (iqs vs iqm mismatch)

Verdict

1 of 1 errors is introduced by this PR. The error is a simple typo in the Makefile where the dtb target name doesn't match the variable name.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1154

PR: #1154
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35585809842

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'arch/arm64/boot/dts/qcom/shikra-iqm-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:384 Yes Typo in dtb target name: shikra-iqm-evk-el2.dtb should be shikra-iqs-evk-el2.dtb to match the variable definition on line 383

Verdict

1 of 1 errors is introduced by this PR. The error occurs in both standard and RT builds.

📎 Detailed analysis: Full report

…MU mappings

Shikra boards currently boot Linux under a hypervisor, where the
remote processor firmware IOMMU streams are managed by the hypervisor.
When booting Linux directly at EL2 without the hypervisor, the IOMMU
is instead managed by the consumer of this DeviceTree, so the firmware
streams for each remote processor need to be described explicitly.

Add an EL2-specific DT overlay and apply it to all Shikra EVK variants
devices to produce an -el2.dtb alongside the "normal" dtb.

Link: https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
Co-developed-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1154 — validate-patch

PR: #1154

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
  2. Lore link matches PR commits: Yes — diff content is identical; Makefile context line offset is due to tree state (PR base has additional camera overlay entries not yet in upstream tree)
  3. Upstream patch status: ✅ ACKed — received Reviewed-by: Abel Vesa (Qualcomm DT maintainer) on 2026-09-21; patch is under review with positive maintainer signal
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1154 - FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings
Upstream commit: https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream ✅ FROMLIST: prefix added correctly; base subject identical
Body preserves rationale ✅ Complete commit body preserved verbatim
Fixes tag present/correct N/A No Fixes tag in upstream or PR (new feature)
Authorship preserved ✅ From: matches lore author (Komal Bajaj); FROMLIST: allows submitter to match author
Backport note (if applicable) N/A FROMLIST: commit, not a backport
Co-developed-by used correctly ✅ Bibek Kumar Patro listed as co-developer with matching Signed-off-by
Link tag present ✅ Correct lore.kernel.org message-ID link included

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Context-only delta — line numbers differ (PR: 369 (@369), lore: 359) due to tree state; added lines identical
arch/arm64/boot/dts/qcom/shikra-el2.dtso ✅ New file content matches lore patch exactly

Upstream Patch Status

The lore thread shows:

  • Posted: 2026-09-18 by Komal Bajaj
  • Reviewed-by: Abel Vesa (2026-09-21) — subsystem maintainer sign-off present
  • Status: ✅ ACKed — Reviewed-by from Abel Vesa (Qualcomm DT maintainer) on 2026-09-21

Community verdict: ✅ ACKed — formal Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com> received from subsystem maintainer

Verdict

Merge as-is. The PR faithfully represents the upstream lore patch with correct FROMLIST: prefix, proper authorship, complete commit message, and identical diff content. The only difference is context line numbers in the Makefile hunk due to tree state divergence, which is expected and correct. The upstream patch has received maintainer review approval.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/r/20260918-shikra-el2-v1-1-07bb072baa31@oss.qualcomm.com
  2. Lore link matches PR commits: Yes — diff content is identical; Makefile context line offset is due to tree state (PR base has additional camera overlay entries not yet in upstream tree)
  3. Upstream patch status: ✅ ACKed — received Reviewed-by: Abel Vesa (Qualcomm DT maintainer) on 2026-09-21; patch is under review with positive maintainer signal
  4. PR present in qcom-next/topics: Yes — integration_presence_report.md confirms all added lines are present in topics branches

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 56321f1b03c171fa3665a6f16a89f47a71a56dad
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #1154 — checker-log-analyzer

PR: #1154
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35593656914

Checker Result Summary
Checker Result Summary
checkpatch ✅ PASS No style issues
dt-binding-check ⏭️ SKIP No binding changes
dtb-check ❌ FAIL 2 genuine errors in EL2 overlay + pre-existing shikra dtb issues
sparse-check ⏭️ SKIP No C/H file changes
check-uapi-headers ⏭️ SKIP No UAPI changes
check-patch-compliance ✅ PASS Link and prefix valid
tag-check ✅ PASS Subject has FROMLIST: prefix (required for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1154 - FROMLIST: arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35593656914

Checker Result Summary
checkpatch ✅ PASS No style issues
dt-binding-check ⏭️ SKIP No binding changes
dtb-check ❌ FAIL 2 genuine errors in EL2 overlay + pre-existing shikra dtb issues
sparse-check ⏭️ SKIP No C/H file changes
check-uapi-headers ⏭️ SKIP No UAPI changes
check-patch-compliance ✅ PASS Link and prefix valid
tag-check ✅ PASS Subject has FROMLIST: prefix (required for qcom-6.18.y)

❌ dtb-check

Root cause: The EL2 overlay adds iommus properties to remoteproc nodes, but the binding schemas don't allow them.

Failure details:

Genuine errors introduced by this PR:

shikra-*-el2.dtb: remoteproc@b800000 (qcom,shikra-lpaicp-pas): 
  iommus: [[54, 864, 5], [54, 870, 0], [54, 231, 0]] is too long
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,shikra-pas.yaml

shikra-*-el2.dtb: remoteproc@b800000 (qcom,shikra-lpaicp-pas): 
  Unevaluated properties are not allowed ('iommus' was unexpected)
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,shikra-pas.yaml

The overlay file arch/arm64/boot/dts/qcom/shikra-el2.dtso:19-22 adds:

&remoteproc_lpaicp {
	iommus = <&apps_smmu 0x0360 0x0005>,
		 <&apps_smmu 0x0366 0x0000>,
		 <&apps_smmu 0x00e7 0x0000>;
};

But the qcom,shikra-pas.yaml binding:

  1. Does not declare iommus as an allowed property (unevaluatedProperties: false rejects it)
  2. If it did allow iommus, the schema expects a different cell count (the array is "too long")

Pre-existing shikra dtb issues (exposed by building new -el2 variants):

The following errors appear in both base and -el2 dtbs and are not caused by this PR:

  • speaker@c (qcom,wsa885x-i2c): compatible string doesn't match qcom SoC naming patterns
  • ethernet@5d00000/5d20000 (qcom,shikra-ethqos): binding schema issues
  • pinctrl@500000 (qcom,shikra-tlmm): unevaluated property emac0-phy-en-hog
  • pmic@0 (qcom,pm2250): audio-codec properties don't match binding
  • dma-controller@4a00000 (qcom,shikra-gpi-dma): interrupts array too long
  • codec@a078000 (qcom,shikra-lpass-va-macro): clock-names mismatch
  • video-codec@5a00000 (qcom,shikra-iris): iommus array too short
  • sram@c11e000 (qcom,shikra-imem): pil-sram compatible string issue

These are tree-wide shikra platform issues unrelated to the EL2 overlay.

Fix:

For the remoteproc errors (blockers):

  1. Update Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml to allow iommus:

    properties:
      iommus:
        minItems: 1
        maxItems: 3  # or whatever the correct max is
  2. OR, if iommus should not be in the binding, verify whether the overlay is adding the correct properties. The binding may expect a different property name or format for SMMU stream IDs in EL2 mode.

  3. Verify the cell count: the binding expects iommus entries with 2 cells <&apps_smmu SID FLAGS>, but the overlay provides 3-cell entries in one case: <&apps_smmu 0x0360 0x0005>. Check if this is correct per the apps_smmu node's #iommu-cells.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk-el2.dtb

Verdict

2 blockers must be fixed before merge:

  1. Add iommus property to qcom,shikra-pas.yaml binding, OR
  2. Remove/correct the iommus property in the EL2 overlay if it's not supposed to be there

The pre-existing shikra dtb issues should be fixed separately and are not blockers for this PR.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ⚠️ skip ❌ Fail ✅ Pass ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️ ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass

Some PAS users require more than one IOMMU mapping. Update
qcom,pas-common.yaml to allow up to three iommus entries so
PAS bindings can represent multi-stream mappings used by
platform device trees and avoid dt-schema array length failures.

Link: https://lore.kernel.org/all/20260930-shikra-el2-v2-1-f0822be5aaee@oss.qualcomm.com/
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ◻️ ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
Probe_Failure_Check ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ❌ Fail
WiFi_Firmware_Driver ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@sgaud-quic

Copy link
Copy Markdown
Contributor

Kernel Checker Analysis

Analyzed failed checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/36720274267

Checker Status Notes
dtb-check ❌ FAIL New Shikra EL2 DTB targets expose Shikra schema validation failures
dt-binding-check ✅ PASS qcom,pas-common.yaml change validates
check-uapi-headers ✅ PASS No UAPI issue
sparse-check ✅ PASS No sparse issue
checkpatch ✅ PASS No formatting issue
check-patch-compliance ✅ PASS Lore links/compliance OK
tag-check ✅ PASS Target is qcom-6.18.y; commits use FROMLIST:

Root Cause

dtb-check fails because this PR adds new composed EL2 DTB targets:

  • shikra-cqm-evk-el2.dtb
  • shikra-cqs-evk-el2.dtb
  • shikra-iqs-evk-el2.dtb

When those targets are validated, the checker reports schema failures from the underlying Shikra base DTBs and their composed EL2 outputs. The EL2 overlay IOMMU additions themselves do not appear to be the direct failing schema issue; the qcom,pas-common.yaml relaxation passed dt-binding-check.

Main Failure Classes

  • qcom,shikra-gpi-dma: interrupts array is too long for Documentation/devicetree/bindings/dma/qcom,gpi.yaml.
  • qcom,shikra-ethqos: compatible is not accepted by qcom,ethqos.yaml; several properties become unevaluated.
  • qcom,shikra-lpass-va-macro: clock-names:1 expected macro.
  • qcom,pil-reloc-info: SRAM child compatible rejected by sram.yaml.
  • qcom,wsa885x-i2c: compatible rejected by qcom-soc.yaml.
  • CQM-specific PMIC audio-codec schema mismatch under qcom,spmi-pmic.yaml.
  • CQS-specific sound card dai-tdm-slot-* properties rejected by qcom,sm8250.yaml.

Recommendation

Do not merge as-is if kernel-checker is required green. Either fix the Shikra DT/schema issues exposed by the new EL2 DTB targets, or split/sequence this PR so the EL2 target additions land after the base Shikra DTBs validate cleanly.

Local repro:

make -j$(nproc) O=temp-out CHECK_DTBS=y qcom/shikra-cqm-evk-el2.dtb
make -j$(nproc) O=temp-out CHECK_DTBS=y qcom/shikra-cqs-evk-el2.dtb
make -j$(nproc) O=temp-out CHECK_DTBS=y qcom/shikra-iqs-evk-el2.dtb

@sgaud-quic
Salendarsingh Gaud (sgaud-quic) merged commit b5a6060 into qualcomm-linux:qcom-6.18.y Oct 1, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants