Skip to content

FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats - #1886

Merged
maulik-k-shah merged 1 commit into
qualcomm-linux:tech/pm/powerfrom
navya-malempati:tech/pm/power-nsp-stats
Sep 30, 2026
Merged

maulik-k-shah merged 1 commit into
qualcomm-linux:tech/pm/powerfrom
navya-malempati:tech/pm/power-nsp-stats

Conversation

@navya-malempati

@navya-malempati navya-malempati commented Sep 23, 2026 •

Copy link
Copy Markdown

Summary

Add SMEM items for four NSP subsystems stats which are present in Nord SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item id. Add new entries for NSP1/2/3.

CRs-Fixed: 4689192

@qcomlnxci
qcomlnxci requested review from a team, maulik-k-shah and smankad-oss and removed request for a team September 23, 2026 06:58
@navya-malempati navya-malempati changed the title soc: qcom: qcom_stats: Add support for NSP subsystem stats FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats Sep 23, 2026
@qcomlnxci
qcomlnxci requested a review from a team September 23, 2026 09:55
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1886

PR: #1886
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35829301482

# Error File:Line PR-introduced? Root Cause
1 GENPD_FLAG_POWER_UNKNOWN undeclared drivers/cpuidle/cpuidle-psci-domain.c:71 No Pre-existing build error in unrelated cpuidle driver; the flag was likely removed or renamed in a recent kernel update but the code wasn't updated accordingly

Verdict

0 of 1 errors are introduced by this PR; 1 is pre-existing. The PR changes to drivers/soc/qcom/qcom_stats.c compiled successfully. The build failure is in an unrelated file (drivers/cpuidle/cpuidle-psci-domain.c) that the PR does not touch.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1886

PR: #1886
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35829301482

# Error File:Line PR-introduced? Root Cause
1 'GENPD_FLAG_POWER_UNKNOWN' undeclared drivers/cpuidle/cpuidle-psci-domain.c:71 No Pre-existing kernel API change — GENPD_FLAG_POWER_UNKNOWN flag removed or renamed in PM domain subsystem

Verdict

0 of 1 errors are introduced by this PR; 1 is pre-existing. This PR is not responsible for the build failure.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1886 — validate-patch

PR: #1886

Verdict Issues Detailed Report
❌ 6 Full report

Final Summary

  1. Lore link present: No — FROMLIST: prefix used but no lore.kernel.org Link tag found in commit message (required for FROMLIST commits)

  2. Lore link matches PR commits: N/A — cannot compare without a lore link

  3. Upstream patch status: Unknown — cannot determine acceptance status without lore link; patch may be pending review, accepted but not yet merged, or rejected

  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1886 - FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats
Upstream commit: N/A (no lore link found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ❌ Cannot verify - no lore link to compare against
Body preserves rationale ❌ Cannot verify - no lore link to compare against
Fixes tag present/correct N/A No Fixes tag in commit (not required for new feature)
Authorship preserved ❌ Cannot verify - no lore link to compare against
Backport note (if applicable) N/A Not a backport (FROMLIST prefix)

Diff

File Status Notes
drivers/soc/qcom/qcom_stats.c ❌ Cannot validate against upstream - no lore link provided

Issues

Critical: Missing lore.kernel.org link

  • The commit uses the FROMLIST: prefix, which by definition means the patch was posted to a mailing list
  • FROMLIST: commits must include a Link: https://lore.kernel.org/r/<message-id> tag in the commit message
  • No lore.kernel.org URL was found in the commit message (no Link: tag, no Patch-mainline: tag, no URL in body)
  • Without a lore link, the patch cannot be validated for:
    • Faithfulness to the upstream posting
    • Upstream acceptance status
    • Correct authorship attribution
    • Completeness of the backport

Integration presence failure

  • The commit is missing from both qcom-next and kernel topics branches (0/1 commits present)
  • This suggests the patch has not been integrated into any Qualcomm kernel branch yet

Verdict

Reject - This PR cannot be merged without correction.

The FROMLIST: prefix requires a lore.kernel.org link to validate the patch content and track upstream status. Add a Link: https://lore.kernel.org/r/<message-id> tag to the commit message pointing to the mailing list posting, then re-submit for validation.

Final Summary

  1. Lore link present: No — FROMLIST: prefix used but no lore.kernel.org Link tag found in commit message (required for FROMLIST commits)

  2. Lore link matches PR commits: N/A — cannot compare without a lore link

  3. Upstream patch status: Unknown — cannot determine acceptance status without lore link; patch may be pending review, accepted but not yet merged, or rejected

  4. PR present in qcom-next/topics: No — FAIL: 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: e428097a36d210c50991063f17ee0848e9eb68a8
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: soc: qcom: qcom_stats: Add support for NSP missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1886 — checker-log-analyzer

PR: #1886
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35829301999

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check ✅ No new sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ Missing subject prefix
tag-check N/A Skipped (target: qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1886 - FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35829301999
Target branch: qcom-next (topic/tech/pm/power)

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check ✅ No new sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ Missing subject prefix
tag-check N/A Skipped (target: qcom-next)

❌ check-patch-compliance

Root cause: The git commit subject line is missing the FROMLIST: prefix that is required by the patch compliance checker.

Failure details:

Checking commit: soc: qcom: qcom_stats: Add support for NSP subsystem stats
Commit summary does not start with a required prefix

The checker detected that the commit subject in the git tree is:

soc: qcom: qcom_stats: Add support for NSP subsystem stats

However, the check-patch-compliance checker requires one of these prefixes:

  • FROMLIST: (patch posted to mailing list)
  • FROMGIT: (patch from maintainer tree)
  • UPSTREAM: (patch merged to mainline)
  • BACKPORT: (backported with modifications)

Note: The patch file (pr.patch) shows FROMLIST: in the email subject line format (Subject: [PATCH] FROMLIST: ...), but the actual git commit subject is missing this prefix. The email format [PATCH] is not the same as the git commit subject.

Fix:

Amend the commit to add the FROMLIST: prefix to the subject line:

git rebase -i HEAD~1   # mark commit as 'edit'
git commit --amend -m "FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats

Add SMEM items for four NSP subsystems stats which are present in Nord
SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
id. Add new entries for NSP1/2/3.

Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>"
git rebase --continue
git push --force-with-lease

Additional recommendation: If this patch has been posted to a mailing list (lore.kernel.org), add a Link: tag to the commit body pointing to the lore URL. This is not strictly required by the checker for qcom-next target, but it's a best practice for tracking upstream submissions.

Reproduce locally:

cd /path/to/kernel
git log --oneline -1 302c1315bd5c
# Verify the subject line starts with FROMLIST:

Verdict

One blocker to fix before merge: Add the FROMLIST: prefix to the commit subject line.

All other checkers passed cleanly. Once the subject prefix is corrected, this PR will be ready to merge.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1886

PR: #1886
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35845800270

# Error File:Line PR-introduced? Root Cause
1 GENPD_FLAG_POWER_UNKNOWN undeclared drivers/cpuidle/cpuidle-psci-domain.c:71 ❌ No Pre-existing error in cpuidle subsystem; PR only modifies drivers/soc/qcom/qcom_stats.c

Verdict

The build failure is NOT caused by this PR. The error is pre-existing in an unrelated file.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1886

PR: #1886
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35845800270

# Error File:Line PR-introduced? Root Cause
1 'GENPD_FLAG_POWER_UNKNOWN' undeclared drivers/cpuidle/cpuidle-psci-domain.c:71 No Pre-existing issue: The GENPD_FLAG_POWER_UNKNOWN flag was removed or renamed in the kernel headers, but cpuidle-psci-domain.c still references it. This is unrelated to the PR's changes to qcom_stats.c.

Verdict

0 of 1 errors are introduced by this PR; 1 is pre-existing. The PR changes are limited to drivers/soc/qcom/qcom_stats.c (adding NSP subsystem stats entries), while the build failure occurs in an unrelated file drivers/cpuidle/cpuidle-psci-domain.c. The PR itself is clean and does not introduce any compilation errors.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1886 — validate-patch

PR: #1886

Verdict Issues Detailed Report
❌ 6 Full report

Final Summary

  1. Lore link present: No — FROMLIST: prefix requires a Link: https://lore.kernel.org/r/<message-id> tag in the commit message, but none was found
  2. Lore link matches PR commits: N/A — cannot compare without a lore link
  3. Upstream patch status: Unknown — cannot check upstream status without lore link; patch may be under review, accepted, or rejected on the mailing list
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1886 - FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats
Upstream commit: N/A (no lore link found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ❌ Cannot verify - no lore link provided
Body preserves rationale ⚠️ Body present but cannot verify against upstream
Fixes tag present/correct N/A No Fixes tag (not a bugfix)
Authorship preserved ❌ Cannot verify - no lore source to compare
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
drivers/soc/qcom/qcom_stats.c ❌ Cannot verify against upstream - no lore link

Issues

Critical: Missing lore.kernel.org link

  • The commit uses FROMLIST: prefix, which indicates the patch was posted to a mailing list
  • Per kernel-topics policy, FROMLIST: commits must include a Link: https://lore.kernel.org/r/<message-id> tag in the commit message
  • Without this link, the patch cannot be validated against its upstream source
  • The lore link is required for:
    • Verifying the diff matches what was posted upstream
    • Checking the upstream review status
    • Ensuring proper attribution and authorship
    • Tracking the patch lifecycle

Missing from integration branches

  • Per integration_presence_report.md: commit is missing from both qcom-next and topics branches
  • This is a validation failure - commits should be present in at least one integration branch before merging

Verdict

Do not merge. Add the required Link: tag pointing to the lore.kernel.org posting before this patch can be validated and merged.

Final Summary

  1. Lore link present: No — FROMLIST: prefix requires a Link: https://lore.kernel.org/r/<message-id> tag in the commit message, but none was found
  2. Lore link matches PR commits: N/A — cannot compare without a lore link
  3. Upstream patch status: Unknown — cannot check upstream status without lore link; patch may be under review, accepted, or rejected on the mailing list
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: e428097a36d210c50991063f17ee0848e9eb68a8
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: soc: qcom: qcom_stats: Add support for NSP missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1886 — checker-log-analyzer

PR: #1886
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35845800124

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no DT binding changes)
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ No sparse warnings in changed code
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ Missing Link trailer
tag-check ✅ Valid FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1886 - FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35845800124

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no DT binding changes)
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ No sparse warnings in changed code
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ Missing Link trailer
tag-check ✅ Valid FROMLIST: prefix present

❌ check-patch-compliance

Root cause: Commit has FROMLIST: prefix but is missing the required Link: trailer pointing to the lore.kernel.org URL.

Failure details:

Checking commit: FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats
No 'Link' found in commit message

Fix: Add a Link: trailer to the commit message body pointing to the lore.kernel.org URL where this patch was posted. The trailer should be placed after the commit description and before the Signed-off-by: line.

Example format:

FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats

Add SMEM items for four NSP subsystems stats which are present in Nord
SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
id. Add new entries for NSP1/2/3.

Link: https://lore.kernel.org/r/<message-id>
Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>

Reproduce locally:

git log --format=fuller 811f1c191db6 -1
# Verify the Link: trailer is missing

To fix:

git rebase -i <base_sha>   # mark commit 811f1c191db6 as 'edit'
git commit --amend         # add Link: trailer in the commit message
git rebase --continue

Verdict

One blocker to fix: Add the Link: trailer pointing to the lore.kernel.org URL where this patch was posted. All other checkers passed cleanly.

@maulik-k-shah

Copy link
Copy Markdown
Contributor

Checking commit: FROMLIST: soc: qcom: qcom_stats: Add support for NSP subsystem stats
No 'Link' found in commit message

Add SMEM items for four NSP subsystems stats which are present in Nord
SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
id. Add new entries for NSP1/2/3.

Link: https://lore.kernel.org/linux-arm-msm/20260908-nord_stats-v1-1-a55adb083d65@oss.qualcomm.com/
Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
@maulik-k-shah
maulik-k-shah merged commit 3faa52e into qualcomm-linux:tech/pm/power Sep 30, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants