Skip to content

FROMLIST: media: i2c: Add Samsung S5KJN5 image sensor driver - #1649

Merged
Wenmeng Liu (wenmliu) merged 2 commits into
qualcomm-linux:tech/mm/camssfrom
wenmliu:tech/mm/camss
Aug 6, 2026
Merged

FROMLIST: media: i2c: Add Samsung S5KJN5 image sensor driver#1649
Wenmeng Liu (wenmliu) merged 2 commits into
qualcomm-linux:tech/mm/camssfrom
wenmliu:tech/mm/camss

Conversation

@wenmliu

Copy link
Copy Markdown
Contributor

CRs-Fixed: 4635675

Add device tree bindings for the Samsung S5KJN5, a 50 MP GBRG 10-bit RAW
MIPI CSI-2 image sensor controlled over CCI.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260724-sk5jn5-v2-1-871d3b9a2e47@oss.qualcomm.com/
Add a V4L2 sub-device driver for the Samsung S5KJN5, a 50 MP GBRG 10-bit
RAW MIPI CSI-2 image sensor. The driver supports the 4096x3072 mode and
exposes the standard controls (exposure, gain, vblank/hblank, test
pattern).

Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260724-sk5jn5-v2-1-871d3b9a2e47@oss.qualcomm.com/
@qcomlnxci
qcomlnxci requested review from a team, quic-vikramsa and svankada and removed request for a team August 6, 2026 07:41
@wenmliu
Wenmeng Liu (wenmliu) merged commit dffc6e9 into qualcomm-linux:tech/mm/camss Aug 6, 2026
4 of 7 checks passed
@qswat-orbit-external

Copy link
Copy Markdown

Change task cannot be moved to Dev Complete

CR: 4635675
Change Task: kernel.qli.0.0
Error: GenAI Assisted field must be set before moving change tasks to Development Complete. Please provide GenAI information.

The change task for this CR cannot be automatically moved to Dev Complete due to the error above. Please resolve the issue mentioned in the error and manually change the change task status to Dev Complete in Orbit.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1649

PR: #1649
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31081895234

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c No Pre-existing conflict between baseline and topic/tech/mm/camss branch
2 Merge conflict during automerge drivers/media/platform/qcom/camss/camss.c No Pre-existing conflict between baseline and topic/tech/mm/camss branch

Verdict

No compilation errors occurred. The build failed during the automerge phase when attempting to merge the topic/tech/mm/camss branch with the baseline. Both merge conflicts are in files that this PR does not modify. This is a pre-existing integration issue unrelated to PR #1649.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1649

PR: #1649
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31081895234

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c No Pre-existing conflict between baseline (qcom-next) and topic branch (tech/mm/camss)
2 Merge conflict during automerge drivers/media/platform/qcom/camss/camss.c No Pre-existing conflict between baseline (qcom-next) and topic branch (tech/mm/camss)

Verdict

No compilation errors found. The build failed during the automerge phase due to 2 merge conflicts in CAMSS driver files that are NOT modified by this PR. These are pre-existing integration conflicts between the baseline and the topic branch.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1649 — validate-patch

PR: #1649

Verdict Issues Detailed Report
1 Full report

Final Summary

  1. Lore link present: Yes - both commits have Link tags, but commit 2/2 has incorrect message-ID
  2. Lore link matches PR commits: Partial - commit 1/2 correct; commit 2/2 has wrong Link tag (points to v2-1 instead of v2-2)
  3. Upstream patch status: ⏳ Decision Pending - posted July 24, 2026 (13 days ago); has Reviewed-by from Krzysztof Kozlowski on patch 1/2; no merge/NAK signals from maintainers yet; only automated AI review comments present
  4. PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1649 - Add Samsung S5KJN5 image sensor driver (2 commits)
Upstream commit: https://lore.kernel.org/all/20260724-sk5jn5-v2-0-871d3b9a2e47@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Both commits: subject matches lore with FROMLIST: prefix added
Body preserves rationale Both commits: body text identical to lore
Fixes tag present/correct N/A No Fixes tag in upstream patches
Authorship preserved FROMLIST: commits: original author's Signed-off-by present in both
Backport note (if applicable) N/A Not a backport - FROMLIST: prefix used

Diff

File Status Notes
Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml Content matches lore patch 1
MAINTAINERS (patch 1) Adds S5KJN5 CAMERA DRIVER entry with dt-bindings file
MAINTAINERS (patch 2) Adds driver file to existing entry
drivers/media/i2c/Kconfig Content matches lore patch 2
drivers/media/i2c/Makefile Content matches lore patch 2
drivers/media/i2c/s5kjn5.c Content matches lore patch 2

Issues

  • Commit 2/2 - Incorrect Link tag: The Link trailer points to https://lore.kernel.org/all/20260724-sk5jn5-v2-1-871d3b9a2e47@oss.qualcomm.com/ (patch 1) instead of the correct message-ID https://lore.kernel.org/all/20260724-sk5jn5-v2-2-871d3b9a2e47@oss.qualcomm.com/ (patch 2). This breaks traceability to the upstream source.

Verdict

Do not merge - Fix the Link tag in commit 2/2 to point to the correct lore message-ID (v2-2 instead of v2-1).

Final Summary

  1. Lore link present: Yes - both commits have Link tags, but commit 2/2 has incorrect message-ID
  2. Lore link matches PR commits: Partial - commit 1/2 correct; commit 2/2 has wrong Link tag (points to v2-1 instead of v2-2)
  3. Upstream patch status: ⏳ Decision Pending - posted July 24, 2026 (13 days ago); has Reviewed-by from Krzysztof Kozlowski on patch 1/2; no merge/NAK signals from maintainers yet; only automated AI review comments present
  4. PR present in qcom-next/topics: Yes - both commits present in topics branch (commit 1: 73eb18e782bb, commit 2: dffc6e97f95f)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: dt-bindings: media: i2c: Add Samsung S5KJN5 partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 73eb18e present
2/2 [PATCH 2/2] FROMLIST: media: i2c: Add Samsung S5KJN5 image sensor partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at dffc6e9 present

Final Status

overall_status: PASS
present_commits: 2/2
partial_commits: 0/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #1649 — checker-log-analyzer

PR: #1649
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31081895216

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Skipped - automerge failed
dt-binding-check ⏭️ Skipped - automerge failed
dtb-check ⏭️ Skipped - automerge failed
sparse-check ⏭️ Skipped - automerge failed
check-uapi-headers ⏭️ Skipped - automerge failed
check-patch-compliance ⏭️ Skipped - automerge failed
tag-check Both commits have valid FROMLIST: prefix
qcom-next-check Both commits already present in topics branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1649 - Add Samsung S5KJN5 image sensor support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31081895216

Checker Result Summary
checkpatch ⏭️ Skipped - automerge failed
dt-binding-check ⏭️ Skipped - automerge failed
dtb-check ⏭️ Skipped - automerge failed
sparse-check ⏭️ Skipped - automerge failed
check-uapi-headers ⏭️ Skipped - automerge failed
check-patch-compliance ⏭️ Skipped - automerge failed
tag-check Both commits have valid FROMLIST: prefix
qcom-next-check Both commits already present in topics branch

⚠️ CI Infrastructure Issue: Automerge Conflicts

Root cause: The kernel-checkers CI workflow failed during the automerge step (integration branch creation) due to merge conflicts in the CAMSS driver, preventing all checker jobs from running.

Failure details:

CONFLICT (content): Merge conflict in drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
CONFLICT (content): Merge conflict in drivers/media/platform/qcom/camss/camss.c
Automatic merge failed; fix conflicts and then commit the result.
Merge failed, manual merge
automerge returned non-zero; check logs for conflicts

Analysis:

This is not a defect in PR #1649. The failure occurred during the CI's pre-check automerge step, which attempts to merge all topic branches together to create an integration branch for testing. The conflicts are in CAMSS driver files that are unrelated to this PR's changes (Samsung S5KJN5 sensor driver and bindings).

Key findings:

  1. PR commits are valid:

    • Commit 1/2: FROMLIST: dt-bindings: media: i2c: Add Samsung S5KJN5
    • Commit 2/2: FROMLIST: media: i2c: Add Samsung S5KJN5 image sensor
    • Both have proper FROMLIST: prefix and lore.kernel.org links
  2. PR commits already integrated:

    • Both commits are already present in the topic/tech/mm/camss branch (exact patch-id matches)
    • Commit 1/2 → 73eb18e782bb in topics
    • Commit 2/2 → dffc6e97f95f in topics
  3. Conflict source:

    • The conflicts are between different topic branches during integration
    • Specifically in camss-csiphy-3ph-1-0.c and camss.c
    • These conflicts exist in the topic branch structure, not in this PR

Fix:

This is a topic branch integration issue that requires maintainer attention:

  1. For PR author: No action needed on your PR. The commits are correctly formatted and already integrated into the topics branch.

  2. For maintainers: The topic/tech/mm/camss branch has conflicts with the baseline during automerge. This needs to be resolved in the topic branch itself:

    # In the kernel tree
    git checkout topic/tech/mm/camss
    git rebase <baseline-ref>
    # Resolve conflicts in:
    #   - drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
    #   - drivers/media/platform/qcom/camss/camss.c
    git push --force-with-lease
  3. Re-trigger CI: Once the topic branch conflicts are resolved, re-run the kernel-checkers workflow.

Reproduce locally:

# Clone kernel-config repo
git clone https://github.com/qualcomm-linux/kernel-config
cd kernel-config

# Run automerge with the same baseline
./automerge --baseline 8d5dbc1b17adf8fe86a41adcda686785e73f5414
# This will reproduce the same merge conflicts

Verdict

PR #1649 is ready to merge - the CI failure is due to pre-existing topic branch integration conflicts unrelated to this PR's changes. The PR commits are properly formatted, have upstream links, and are already present in the topics branch. No changes required to the PR itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants