Skip to content

arm64: defconfig: Enable OV08X40 camera sensor driver - #1633

Open
Nihal Kumar Gupta (nihal231998) wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
nihal231998:ov08x_enable
Open

arm64: defconfig: Enable OV08X40 camera sensor driver#1633
Nihal Kumar Gupta (nihal231998) wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
nihal231998:ov08x_enable

Conversation

@nihal231998

@nihal231998 Nihal Kumar Gupta (nihal231998) commented Aug 3, 2026

Copy link
Copy Markdown

Set CONFIG_VIDEO_OV08X40=m to enable the OmniVision OV08X40 in four-lane CSIPHY4 mode.

Sibi said defconfig updates should come from the tech/all/config branch.
Cherry-pick the changes: #1304

CR-Fixed: https://orbit/CR/4631603

Add CONFIG_VIDEO_OV08X40=m to enable the OmniVision OV08X40
CSIPHY4 in four lane mode.

Signed-off-by: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, Dmitry Baryshkov (lumag), Shivendra Pratap (quicAspratap) and yijiyang and removed request for a team August 3, 2026 12:17
@qlijarvis

Copy link
Copy Markdown

PR #1633 — validate-patch

PR: #1633

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required for work-in-progress commits
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: indicates work-in-progress, not yet posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1633 - PENDING: arm64: defconfig: Enable OV08X40 camera sensor driver
Upstream commit: N/A (PENDING: prefix indicates work-in-progress, not yet posted upstream)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix; no upstream source to compare
Body preserves rationale Clear description of what is being enabled
Fixes tag present/correct N/A Not applicable for defconfig addition
Authorship preserved Author and Signed-off-by present and consistent
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/defconfig Clean addition of CONFIG_VIDEO_OV08X40=m in correct alphabetical position

Issues

  • Integration presence: Commit is missing from both qcom-next and kernel-topics branches. For a PENDING commit, this may be expected if it's truly work-in-progress, but it should be tracked for eventual integration.

Verdict

The patch itself is technically correct: it adds a single config option in the proper location with a clear commit message. However, the PENDING status and absence from integration branches means this is work-in-progress that should not be merged to production branches until it progresses through the proper upstream workflow.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required for work-in-progress commits
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: indicates work-in-progress, not yet posted upstream
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (1/1 commits missing). For PENDING commits this may be expected, but integration status should be tracked.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: defconfig: Enable OV08X40 camera sensor missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1633 — checker-log-analyzer

PR: #1633
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30812973730

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Invalid prefix: PENDING:
tag-check Invalid prefix: PENDING:

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1633 - PENDING: arm64: defconfig: Enable OV08X40 camera sensor driver
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30812973730
Target branch: tech/all/config

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Invalid prefix: PENDING:
tag-check Invalid prefix: PENDING:

❌ check-patch-compliance

Root cause: Commit uses PENDING: prefix, which is not in the allowed list for check-patch-compliance.

Failure details:

Checking commit: PENDING: arm64: defconfig: Enable OV08X40 camera sensor driver
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: — patch posted to lore.kernel.org
  • FROMGIT: — patch from a maintainer git tree
  • UPSTREAM: — patch merged into Linus's mainline
  • BACKPORT: — upstream patch backported with modifications

The commit uses PENDING:, which is a vendor-internal prefix for work-in-progress patches not yet posted upstream. This is a known checker limitationPENDING: commits will always fail check-patch-compliance.

Fix options:

  1. If this patch has been posted to a mailing list:

    git rebase -i <base_sha>   # mark commit as 'edit'
    git commit --amend -m "FROMLIST: arm64: defconfig: Enable OV08X40 camera sensor driver"
    # Add Link: <lore-url> to the commit body
    git rebase --continue
  2. If this is vendor-only (not posted upstream):

    • Change prefix to QCLINUX: (but note: this will also fail the checker — known limitation)
    • Or accept that PENDING: commits will fail this check until posted upstream

Reproduce locally:

cd kernel
../kernel-checkers/check-patch-compliance.sh

❌ tag-check

Root cause: Target branch tech/all/config requires all commits to have a valid subject prefix, but PENDING: is not accepted by the upstream-focused checker.

Analysis:

Since the target branch is not qcom-next or qcom-next-staging, every commit must start with one of these prefixes:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

The commit does have a prefix (PENDING:), which satisfies the tag-check requirement for subject-line formatting. However, check-patch-compliance enforces a stricter subset and rejects PENDING: and QCLINUX:.

Verdict on tag-check:PASS (subject has a valid prefix tag)
Verdict on check-patch-compliance:FAIL (prefix not in allowed upstream-linkable list)


Recommendation

1 blocker to fix before merge:

The commit uses PENDING: prefix, which fails check-patch-compliance. This checker enforces upstream-linkable prefixes only (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Action required:

  • If the OV08X40 driver enablement has been posted to a mailing list: Change prefix to FROMLIST: and add Link: <lore-url> to the commit body.
  • If this is vendor-only work-in-progress: Accept that PENDING: commits will fail this checker until posted upstream, or use QCLINUX: (which will also fail — known limitation for vendor-only commits).

Note: This is a defconfig-only change (enabling an existing driver module). If the driver itself is already upstream, consider posting this defconfig change to the arm64 defconfig maintainers and using FROMLIST: prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants