Skip to content

QCLINUX: debug: Enable wlan Ath10k debug config - #1616

Merged
Komal Bajaj (Komal-Bajaj) merged 1 commit into
qualcomm-linux:tech/all/configfrom
linghuiwu-star:ath10k-debug-config-mainline
Aug 4, 2026
Merged

QCLINUX: debug: Enable wlan Ath10k debug config#1616
Komal Bajaj (Komal-Bajaj) merged 1 commit into
qualcomm-linux:tech/all/configfrom
linghuiwu-star:ath10k-debug-config-mainline

Conversation

@linghuiwu-star

@linghuiwu-star linghuiwu (linghuiwu-star) commented Jul 31, 2026

Copy link
Copy Markdown

Enable ATH10K debug, debugfs, tracing, and devcoredump support in kernel/configs/debug.config. This complements the existing Qualcomm
WLAN debug configs for ATH11K and ATH12K and enables ath10k firmware crash debugging.

CRs-Fixed: 4631153

@linghuiwu-star
linghuiwu (linghuiwu-star) changed the base branch from main to tech/all/config July 31, 2026 12:44
@linghuiwu-star linghuiwu (linghuiwu-star) changed the title Ath10k debug config add QCLINUX: debug: Enable wlan Ath10k debug config Aug 3, 2026
@linghuiwu-star

Copy link
Copy Markdown
Author

Hi Komal Bajaj (@Komal-Bajaj) , Help review and approve

Comment thread kernel/configs/debug.config Outdated
CONFIG_ATH12K_DEBUG=y
CONFIG_ATH12K_DEBUGFS=y
CONFIG_ATH12K_TRACING=y
CONFIG_ATH10K_DEBUG=y

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add in alphabetical order

@qcomlnxci
qcomlnxci requested review from a team, Komal Bajaj (Komal-Bajaj), Rajendra (rrnayak) and Shiraz Hashim (shashim-quic) and removed request for a team August 4, 2026 08:34
@qlijarvis

Copy link
Copy Markdown

PR #1616 — validate-patch

PR: #1616

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1616 - QCLINUX: debug: Enable ATH10K debug configs
Upstream commit: N/A (vendor-only change)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear explanation of purpose and context
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved N/A Vendor commit; no upstream author
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
kernel/configs/debug.config Adds 4 ATH10K debug configs; logically placed after ATH12K configs

Issues

None. The commit is well-formed for a vendor-only configuration change.

Verdict

Merge as-is. This is a properly formatted vendor-only commit that adds ATH10K debug configuration options to complement existing ATH11K and ATH12K debug support.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (expected for new PR)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: debug: Enable ATH10K debug configs missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1616 — checker-log-analyzer

PR: #1616
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30892542275

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: commit body line too long
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTS changes
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance QCLINUX: prefix not accepted (known limitation)
tag-check Subject has valid prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1616 — QCLINUX: debug: Enable ATH10K debug configs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30892542275

Checker Result Summary
checkpatch 1 warning: commit body line too long
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTS changes
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance QCLINUX: prefix not accepted (known limitation)
tag-check Subject has valid prefix

❌ checkpatch

Root cause: Commit body line exceeds 75 characters (line #6 is 178 characters).

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6: 
Enable ATH10K debug, debugfs, tracing, and devcoredump support in debug.config. This complements the existing Qualcomm WLAN debug configs for ATH11K and ATH12K and enables ath10k firmware crash debugging.

6c73c8ea9b2fb110d22c805008def4624239f698 total: 0 errors, 1 warnings, 0 checks, 10 lines checked

Fix: Wrap the commit body at 75 characters:

git rebase -i 273eb73f8cbad797fb4e7e7449166f3721631f8e   # mark commit as 'edit'
git commit --amend
# Edit the commit message to wrap the body:
#
# QCLINUX: debug: Enable ATH10K debug configs
#
# Enable ATH10K debug, debugfs, tracing, and devcoredump support in
# debug.config. This complements the existing Qualcomm WLAN debug
# configs for ATH11K and ATH12K and enables ath10k firmware crash
# debugging.
#
# Signed-off-by: Linghui Wu <linghui.wu@oss.qualcomm.com>

git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 273eb73f8cbad797fb4e7e7449166f3721631f8e..6c73c8ea9b2fb110d22c805008def4624239f698

❌ check-patch-compliance

Root cause: The QCLINUX: prefix is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: debug: Enable ATH10K debug configs
Commit summary does not start with a required prefix
##[error]Process completed with exit code 1.

Analysis: This is a known limitation of the check-patch-compliance checker. The checker enforces upstream-linkable prefixes only and does not accept vendor-internal prefixes like QCLINUX: or PENDING:.

Context:

  • This is a vendor-only config change with no upstream equivalent (kernel config fragments are not upstreamed).
  • The commit correctly uses the QCLINUX: prefix to indicate vendor-only content.
  • The tag-check (Step 2.7) confirms that QCLINUX: is a valid prefix for branches other than qcom-next/qcom-next-staging.

Fix: None required. This is expected behavior for vendor-only commits. The checker will always fail for QCLINUX:-prefixed commits — this is a known checker limitation, not a patch defect.

Alternative (if upstream linkage is desired): If this config change is related to an upstream patch series, change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org thread. However, since kernel config fragments are vendor-specific and not upstreamed, QCLINUX: is the correct prefix.


Verdict

1 blocker to fix before merge:

  • Wrap the commit body at 75 characters to resolve the checkpatch warning.

1 expected failure (no action needed):

  • check-patch-compliance fails for QCLINUX: prefix — this is a known checker limitation for vendor-only commits. The prefix is correct and the tag-check confirms it is valid.

@qcomlnxci
qcomlnxci requested a review from a team August 4, 2026 09:20
Enable ATH10K debug, debugfs, tracing, and devcoredump support in
kernel/configs/debug.config. This complements the existing Qualcomm WLAN
debug configs for ATH11K and ATH12K and enables ath10k firmware crash
debugging.

Signed-off-by: Linghui Wu <linghui.wu@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1616 — validate-patch

PR: #1616

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1616 - QCLINUX: debug: Enable ATH10K debug configs
Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream source
Body preserves rationale Clear explanation of what and why
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved From: matches Signed-off-by:
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
kernel/configs/debug.config Adds 4 ATH10K debug configs; consistent with existing ATH11K/ATH12K pattern

Verdict

Merge as-is. This is a well-formed vendor-only commit that adds ATH10K debug configuration options to complement existing ATH11K and ATH12K debug configs. The change is focused, properly documented, and follows kernel config conventions.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (expected for new vendor-only change awaiting merge)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: debug: Enable ATH10K debug configs missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1616 — checker-log-analyzer

PR: #1616
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30896939699

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTS changes
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX: prefix not accepted (known limitation)
tag-check Valid prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1616 - QCLINUX: debug: Enable ATH10K debug configs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30896939699
Target branch: tech/all/config

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTS changes
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX: prefix not accepted (known limitation)
tag-check Valid prefix present

❌ check-patch-compliance

Root cause: The commit uses QCLINUX: prefix, which is a vendor-internal prefix not accepted by the check-patch-compliance checker.

Failure details:

Checking commit: QCLINUX: debug: Enable ATH10K debug configs
Commit summary does not start with a required prefix

Analysis:

This is a known checker limitation for vendor-only commits. The check-patch-compliance checker enforces upstream-linkable prefixes only and accepts:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged to mainline)
  • BACKPORT: (backported with modifications)

The commit uses QCLINUX:, which is a valid vendor-internal prefix used in the tree for Qualcomm-specific changes with no upstream equivalent. However, check-patch-compliance does not recognize QCLINUX: or PENDING: as valid prefixes.

Why this commit uses QCLINUX:

This is a vendor-specific kernel config change (enabling ATH10K debug configs in kernel/configs/debug.config). It is not posted upstream and has no upstream equivalent, making QCLINUX: the appropriate prefix.

Fix options:

  1. Accept the failure (Recommended): This is a known limitation of the checker for vendor-only commits. The QCLINUX: prefix is correct for this type of change. The checker will always fail for vendor-only commits, but this does not block merge if the change is valid.

  2. Change to FROMLIST: (Not recommended): Only if you plan to post this config change upstream to lore.kernel.org. You would also need to add a Link: trailer pointing to the lore URL. However, kernel config fragments are typically not upstreamed.

Note on tag-check:

The target branch is tech/all/config (not qcom-next or qcom-next-staging), so the mandatory subject-prefix check applies. The commit passes tag-check because QCLINUX: is a valid prefix in the broader set of allowed prefixes (FROMLIST, FROMGIT, UPSTREAM, BACKPORT, QCLINUX, PENDING, WORKAROUND).

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base <base_sha> \
  --head <head_sha>

Verdict

1 known limitation (not a blocker): The check-patch-compliance failure is expected for vendor-only commits using QCLINUX: prefix. This is a known checker limitation and does not indicate a problem with the patch itself.

Recommendation: Merge as-is. The commit is correctly formatted with the appropriate QCLINUX: prefix for a vendor-specific config change. All other checkers passed or were correctly skipped.

@Komal-Bajaj
Komal Bajaj (Komal-Bajaj) merged commit 54a7c0e into qualcomm-linux:tech/all/config Aug 4, 2026
6 of 7 checks passed
@qswat-orbit-external

Copy link
Copy Markdown

Change task cannot be moved to Dev Complete

CR: 4631153
Change Task: kernel.qli.0.0
Error: GenAI Assisted field must be set before moving change tasks to Development Complete. Please provide GenAI information.

The change task for this CR cannot be automatically moved to Dev Complete due to the error above. Please resolve the issue mentioned in the error and manually change the change task status to Dev Complete in Orbit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants