Skip to content

QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1 - #1491

Open
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
mvadlama-lab:cam1_imx_kodiak_qli0.0
Open

QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1#1491
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
mvadlama-lab:cam1_imx_kodiak_qli0.0

Conversation

@mvadlama-lab

@mvadlama-lab mvadlama-lab commented Jul 10, 2026

Copy link
Copy Markdown

CAM1 port is currently enabled for OV9282.This change adds DTSI configuration for IMX577 so that CAM1 can also support IMX577 sensor on the hardware platform of QCM6490 Dev.

CRs-Fixed: 4633982

@qcomlnxci
qcomlnxci requested review from a team, Kaushal Kumar (quic-kaushalk), Rajendra (rrnayak) and Shiraz Hashim (shashim-quic) and removed request for a team July 10, 2026 06:19
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1491

PR: #1491
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29073521607

# Error File:Line PR-introduced? Root Cause
1 Missing header file arch/arm64/boot/dts/qcom/glymur-crd-camx.dtso:9 No Pre-existing: Missing dt-bindings/clock/qcom,glymur-camcc.h header file
2 Device tree overlay application failure arch/arm64/boot/dts/qcom/hamoa-evk-camx.dtbo No Pre-existing: FDT_ERR_NOTFOUND when applying hamoa-evk-camx overlay

Verdict

All 2 errors are pre-existing issues; 0 errors are introduced by this PR. The PR only modifies qcs6490-rb3gen2-camera-sensor.dtsi and does not touch the failing files.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1491 — validate-patch

PR: #1491

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: No — commit not found in qcom-next branch (searched by subject, file path, and diff fingerprint)
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1491 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS (vendor-only)

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream source
Body preserves rationale Clear description of CAM1 port IMX577 support
Fixes tag present/correct N/A New feature addition; no Fixes tag required
Authorship preserved Author: Vadlamani Manjusha mvadlama@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi Adds 78 lines: eeprom_cam1 and qcom,cam-sensor12 nodes for IMX577

Issues

None. This is a vendor-specific device tree addition with proper QCLINUX: prefix indicating no upstream equivalent is expected.

Verdict

Merge as-is. This is a properly formatted vendor-only commit adding IMX577 camera sensor support to the QCM6490 RB3 Gen2 platform. The QCLINUX: prefix correctly indicates this is Qualcomm-specific configuration with no upstream lore link required.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: No — commit not found in qcom-next branch (searched by subject, file path, and diff fingerprint)

@qlijarvis

Copy link
Copy Markdown

PR #1491 — checker-log-analyzer

PR: #1491
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29073521783

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check N/A Cannot evaluate - CI setup failed
qcom-next-check N/A Cannot evaluate - CI setup failed

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1491 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29073521783

Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check N/A Cannot evaluate - CI setup failed
qcom-next-check N/A Cannot evaluate - CI setup failed

⚠️ CI Infrastructure Failure

Root cause: The CI workflow attempted to merge PR #1491 from qualcomm-linux/kernel-topics (targeting branch tech/overlay/dt) into the qcom-next baseline after running automerge, but the two branches have completely unrelated git histories.

Failure details:

All six checker jobs failed at the merge preparation step with identical errors:

Syncing qcom-next baseline...
Running automerge...
Done, merged 1 topic(s).
Fetching PR #1491 from https://github.com/qualcomm-linux/kernel-topics.git...
Merging pr-1491 (no-commit)...
fatal: refusing to merge unrelated histories
Merge failed or conflicts detected. Aborting merge.
##[error]Process completed with exit code 3.

Analysis:

This is not a patch quality issue. The PR contains a single commit adding IMX577 camera sensor DTSI configuration for QCM6490 RB3 Gen2. The patch itself appears well-formed with proper:

  • Subject line with QCLINUX: prefix (vendor-specific change)
  • Signed-off-by trailer
  • DTS-only changes (78 lines added to qcs6490-rb3gen2-camera-sensor.dtsi)

The failure occurred because:

  1. PR context: PR QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1 #1491 is from qualcomm-linux/kernel-topics repository targeting branch tech/overlay/dt
  2. CI workflow behavior: The kernel-checkers CI workflow is configured to:
    • Clone qualcomm-linux/kernel (not kernel-topics)
    • Check out qcom-next baseline
    • Run automerge to integrate topic branches
    • Then attempt to merge the PR from kernel-topics
  3. Root cause: The tech/overlay/dt branch in kernel-topics has a completely different git history than qcom-next in the main kernel repository, causing git to refuse the merge with "unrelated histories"

Fix:

This is a CI workflow configuration issue, not a patch defect. The workflow needs to be updated to handle PRs from kernel-topics repository correctly. Possible solutions:

  1. Option A (Recommended): Update the CI workflow to detect when topic_repo is kernel-topics and skip the automerge step, directly checking out the target branch from kernel-topics instead of kernel

  2. Option B: Use git merge --allow-unrelated-histories flag when merging PRs from kernel-topics (though this may not be semantically correct)

  3. Option C: Reconfigure the PR to target a branch in the main qualcomm-linux/kernel repository instead of kernel-topics

Reproduce locally:

# This demonstrates the issue:
git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout qcom-next
git fetch https://github.com/qualcomm-linux/kernel-topics.git refs/pull/1491/head:pr-1491
git merge pr-1491 --no-commit
# Result: fatal: refusing to merge unrelated histories

Patch quality assessment:

Since no checkers actually ran on the patch content, I cannot provide a complete quality assessment. However, from manual inspection of pr.patch:

Looks good:

  • Proper commit message format
  • QCLINUX: prefix appropriate for vendor-specific camera sensor configuration
  • Signed-off-by present
  • DTS-only changes (no C code to check with sparse/checkpatch)
  • No binding changes (dt-binding-check would skip)

⚠️ Cannot verify without CI run:

  • checkpatch style compliance (indentation, line length, etc.)
  • dtb-check validation (whether the new nodes compile and validate against schemas)

Verdict

CI workflow configuration issue - no patch changes required.

The patch cannot be evaluated because the CI infrastructure failed during the merge preparation step before any checkers could run. This is a known issue when PRs from kernel-topics repository target branches with unrelated git histories to the main kernel repository's qcom-next baseline.

Recommended actions:

  1. For CI maintainers: Update the kernel-checkers workflow to handle kernel-topics PRs correctly (see Option A above)
  2. For PR author: Consider whether this PR should target a different repository/branch, or wait for CI workflow fix
  3. For reviewers: Manual review of the patch content is required since automated checkers could not run

The patch itself appears well-formed from manual inspection, but automated validation is blocked by the CI infrastructure issue.

gpio-no-mux = <0>;
pinctrl-names = "cam_default", "cam_suspend";
pinctrl-0 = <&cam_sensor_mclk1_active
&cam_sensor_active_rst1>;

@Komal-Bajaj Komal Bajaj (Komal-Bajaj) Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please align it properly

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gpio-custom1 = <2>;
gpio-req-tbl-num = <0 1 2>;
gpio-req-tbl-flags = <1 0 0>;
gpio-req-tbl-label = "CAMIF_MCLK1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gpio-no-mux = <0>;
pinctrl-names = "cam_default", "cam_suspend";
pinctrl-0 = <&cam_sensor_mclk1_active
&cam_sensor_active_rst1>;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gpio-req-tbl-num = <0 1 2>;
gpio-req-tbl-flags = <1 0 0>;
gpio-req-tbl-label = "CAMIF_MCLK1",
"CAM_RESET1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CAM1 port is currently enabled for OV9282.This change adds
DTSI configuration for IMX577 so that CAM1 can also support
IMX577 sensor on the hardware platform of QCM6490 Dev.

Signed-off-by: Vadlamani Manjusha <mvadlama@qti.qualcomm.com>
@mvadlama-lab
mvadlama-lab force-pushed the cam1_imx_kodiak_qli0.0 branch from 473f652 to 480a74d Compare August 5, 2026 10:32
@qcomlnxci
qcomlnxci requested a review from a team August 5, 2026 10:34
@qlijarvis

Copy link
Copy Markdown

PR #1491 — validate-patch

PR: #1491

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1491 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Upstream commit: N/A (vendor-only commit)
Verdict: ⏭️ SKIP (vendor-only, not applicable for upstream validation)

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of CAM1 IMX577 sensor support
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi Adds eeprom_cam1 and qcom,cam-sensor12 nodes for IMX577 sensor

Verdict

This is a vendor-only commit (QCLINUX: prefix) adding device tree configuration for IMX577 camera sensor support on QCM6490 RB3Gen2. No upstream validation is applicable. The commit message is clear, authorship is correct, and the diff adds appropriate DT nodes for the camera sensor.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified" in qcom-next; missing from topics branches

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1491 — checker-log-analyzer

PR: #1491
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30997937806

Checker Result Summary
Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check Test passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX: prefix not in allowed list (known limitation)
tag-check Valid prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1491 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30997937806

Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check Test passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX: prefix not in allowed list (known limitation)
tag-check Valid prefix present

❌ checkpatch

Root cause: Two Qualcomm camera-specific compatible strings lack DT binding documentation.

Failure details:

WARNING: DT compatible string "qcom,eeprom" appears un-documented -- check ./Documentation/devicetree/bindings/
#26: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:180:
+		compatible = "qcom,eeprom";

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#64: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:218:
+		compatible = "qcom,cam-sensor";

480a74de6b93f4a02f8d14799b033c41b8d2ec49 total: 0 errors, 2 warnings, 0 checks, 84 lines checked

Fix:

These are vendor-specific camera subsystem compatible strings used throughout the Qualcomm camera driver stack. Two options:

  1. Add binding documentation (recommended if these are stable interfaces):

    • Create Documentation/devicetree/bindings/media/qcom,eeprom.yaml
    • Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml
    • Document the required/optional properties for each
  2. Accept the warnings (if these are internal-only interfaces):

    • These warnings are informational for vendor-specific camera nodes
    • The DTS change is valid; bindings can be added later when upstreaming

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git c748456ceab4..65b7650bc793

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Commit summary does not start with a required prefix

Fix:

This is a known checker limitation for vendor-only commits. The QCLINUX: prefix is valid and widely used in the Qualcomm kernel tree for vendor-specific changes that have no upstream equivalent.

No action required — this failure is expected for vendor-only DTS additions. The commit prefix is correct for this type of change.

If this commit were to be posted upstream in the future, the prefix would need to change to FROMLIST: and a Link: trailer would need to be added pointing to the lore.kernel.org URL.


Verdict

2 blockers to address before merge:

  1. checkpatch warnings — Add DT binding documentation for qcom,eeprom and qcom,cam-sensor, or accept the warnings if these are internal-only camera subsystem interfaces.

  2. check-patch-compliance failure — This is a known limitation of the checker for QCLINUX: prefixed commits. No patch change needed; the prefix is correct for vendor-only changes.

Recommendation: If the camera compatible strings are stable and intended for long-term use, add binding documentation. Otherwise, the warnings can be accepted as-is for vendor-specific camera nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants