Repository navigation
ci: no Qlip build on a develop push; restart pings on the main webhook (0.10.73) - #159
Merged
Merged
Conversation
A push to develop ran the story suite with QLIP_UPLOAD_TOKEN set, so every merge uploaded a Qlip build. The Qlip server promotes a merged PR's accepted baselines onto develop itself, so the next PR already diffs against them; the develop build only ever added an unowned pending build whose accepts moved a flaky capture onto trunk. The token is now set for a pull request only; the suite still runs on develop and, with no token, qlip captures without uploading. With no build on a develop push, the Discord message carried a "[Qlip visual tests]()" link to nowhere. qlip-build-link.sh now prints the whole link as `link=`, which is empty when no build was uploaded, and the messages use that. The "please do not restart Qorus on Rippy" warning and its "safe to restart" follow-up posted through the development channel's webhook and were a constant ping there. They use DISCORD_WEBHOOK now, like every other notification in the file. Version 0.10.71, the one bump this PR makes. Closes #158 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
📦 Prerelease published for this PR: Install it in a consumer (updates yarn add @qoretechnologies/reqraft@0.10.73-pr.159.g64f9f7cPublished under the |
qlip visual regression✅ No visual changes. |
… 0.10.73 develop released 0.10.71 and 0.10.72 while this PR was open, so the branch's bump to 0.10.71 conflicted with it. The merge takes develop's package.json and bumps once more, to 0.10.73. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
nickmazurenko
self-requested a review
November 5, 2026 11:00
nickmazurenko
approved these changes
Nov 5, 2026
Foxhoundn
changed the title
davidnich
added a commit
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158.
What
developno longer uploads a Qlip build:QLIP_UPLOAD_TOKENis set for a pull request only. The suite still runs on develop; with no token, qlip captures without uploading.qlip-build-link.shprints the Discord link as a whole (link=), empty when no build was uploaded, so a develop push's message has no link instead of a[Qlip visual tests]()that goes nowhere. Its test covers the new output and the workflow's use of it.DISCORD_WEBHOOK, like every other notification in the file, instead ofDISCORD_WEBHOOK_DEV.Why
The develop build existed to give the next PR fresh develop baselines. The Qlip server does that itself: when a PR merges, its accepted baselines are promoted onto
develop(qlip-server,routes/webhooks.github.ts,pull_requestclosed + merged), and the next PR diffs against them. The develop build on top of that only ever added an unowned pending build that nobody reviews, and accepting one moved a flaky capture onto trunk for every PR to diff against.The restart warnings went to the development channel, where they were constant noise.
Checks
yarn precheck: lint clean, 3310 unit tests pass (three timed out once while two other suites loaded the machine, and pass alone), both type builds clean.Same change: qorus-saas-landing #41, qorus-ide #307, qlip-ui #63.
🤖 Generated with Claude Code