You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes delayed error reporting when an embedding worker crashes before returning a result. With this, waits retry in short intervals and report the failed worker without resetting the overall timeout.
Four regression cases fail on the original code. The focused tests pass on Python 3.10, 3.12 and 3.14. The full suite passes with 203 passed and 13 skipped. The configured type checks and pre-commit checks pass.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 29faecd5-19cf-44ab-b70d-8d04d14e1f79
📥 Commits
Reviewing files that changed from the base of the PR and between de502ca and 0730679.
📒 Files selected for processing: 2
fastembed/parallel_processor.py
tests/test_worker_crash_wait.py
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
📝 Walkthrough
semi_ordered_map now uses _get_output for both blocking output reads. _get_output polls the output queue in intervals of up to one second, checks worker health after an empty read, and raises Empty when the configured processing timeout expires. New tests cover worker crashes during waits, delayed results, timeout behavior, and process cleanup.
Worker crashes during output waits can now be reported promptly without extending the configured timeout. No merge-blocking issue was identified.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 2 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: checking worker health during output waits.
Description check
The description is directly related to the changeset and explains the worker-crash handling, timeout behavior, tests, and validation results.
Linked Issues check
Issue #823 is directly linked and remains open. The PR replaces both blocking output reads in semi_ordered_map with _get_output. _get_output polls for at most one second, calls `check_worker_hea…
Out of Scope Changes check
The changes stay within issue #823. The production change only adds health checks to output waits and the tests provide regression coverage for the requested crash and timeout behavior. No unrelated p…
Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes delayed error reporting when an embedding worker crashes before returning a result. With this, waits retry in short intervals and report the failed worker without resetting the overall timeout.
Fixes #823
Four regression cases fail on the original code. The focused tests pass on Python 3.10, 3.12 and 3.14. The full suite passes with 203 passed and 13 skipped. The configured type checks and pre-commit checks pass.