Skip to content

fix(tutorials): correct polynomial autograd function - #3997

Open
Sahas2711 wants to merge 1 commit into
pytorch:mainfrom
Sahas2711:fix/pytorch-torch-sin-tutorial-3996
Open

Sahas2711 wants to merge 1 commit into
pytorch:mainfrom
Sahas2711:fix/pytorch-torch-sin-tutorial-3996

Conversation

@Sahas2711

Copy link
Copy Markdown

Summary

Changed torch.exp(x) to torch.sin(x) in the polynomial autograd tutorial (beginner_source/examples_autograd/polynomial_autograd.py).

Problem

The tutorial's docstring states it is trained to predict y = sin(x), but line 31 computed y = torch.exp(x). This made the tutorial learn a different function than the one described and used elsewhere in the series.

Solution

Replaced the incorrect torch.exp(x) with torch.sin(x) so the targets match the documented y = sin(x). No other changes; the polynomial model (y = a + b x + c x^2 + d x^3) and training loop are unchanged.

Testing

  • git diff --check — no whitespace errors.
  • Single-line change; Python syntax unchanged (was valid, remains valid).
  • Full tutorial execution requires GPU shards and could not be run in this environment.

Changes

  • beginner_source/examples_autograd/polynomial_autograd.py — torch.exp(x) → torch.sin(x)

Issue reference

Closes #3996

Copilot AI balanced review requested due to automatic review settings November 9, 2026 16:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@pytorch-bot

pytorch-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3997

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla

meta-cla Bot commented Nov 9, 2026

Copy link
Copy Markdown

Hi @Sahas2711!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@pytorch-bot

pytorch-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

The following ciflow label(s) have been added but CI has not been triggered yet because the workflows are awaiting approval:

  • ciflow/docs

Once a maintainer approves the workflows (scroll to the bottom of the PR page), the corresponding CI jobs will be triggered automatically. Please ping one of the reviewers if you do not have access to approve and run workflows.

@meta-cla meta-cla Bot added the cla signed label Nov 10, 2026
@meta-cla

meta-cla Bot commented Nov 10, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - torch.exp instead of torch.sin in Justin Johnson tutorial 3

2 participants