Conversation
|
Hi @skpark-rh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
I don't know what number this RFC should be so I left it |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
PyTorch currently only has distributed tests for single-node testing. This RFC aims to address this limitation and turn on cross node testing. The solution is to add a no-op attribute,
local_rank, toMultiProcessTestBasethat differentiate what is global and what is local.Scope
Phase 1 is to add the attribute
local_ranktoMultiProcessTestCase.Phase 2 is to change every instance of
torch.devicein the child classes ofMultiProcessTestCaseto refer toself.local_rankinstead ofself.rank.Feedback
In this RFC, I would like feed back on two questions.
local_rankvs alternatives), and whether it's set via env (LOCAL_RANK) or from computation.