Repository navigation
[executorch][native-ggml] Reject weight-only quantized linears unless activation quant is allowed - #24536
Closed
pytorchbot wants to merge 1 commit into
Closed
[executorch][native-ggml] Reject weight-only quantized linears unless activation quant is allowed#24536pytorchbot wants to merge 1 commit into
pytorchbot wants to merge 1 commit into
Conversation
… activation quant is allowed Pull Request resolved: #24361 ggml quantizes the activations of its quantized matmuls, so weight-only int4 and GGUF linears silently ran with numerics the PTN doesn't describe. Compile now rejects them unless `GgmlEngineOptions::allow_activation_quant_for_weight_only` is set. `ggml_ptn_runner` and `run_hf_llm_ggml` expose it as `--allow_activation_quant_for_weight_only`, which GGUF LLMs on ggml now need. Authored with Claude Code. @bypass-github-export-checks @bypass-github-pytorch-ci-checks @bypass-github-executorch-ci-checks ghstack-source-id: 463657742 @exported-using-ghexport Differential Revision: [D128254887](https://our.internmc.facebook.com/intern/diff/D128254887/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24536
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 77f2cad with merge base 0f8e096 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
digantdesai
approved these changes
Nov 5, 2026
digantdesai
approved these changes
Nov 5, 2026
Contributor
|
Landed on main via #24698. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #24361 by @digantdesai
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/digantdesai/188/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/188/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/digantdesai/187/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/188/orig
@diff-train-skip-merge