Repository navigation
[release/1.6] Fix CUDA indexing, graph execution and output buffers - #24488
Merged
JacobSzwejbka merged 1 commit intoNov 3, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24488
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New FailuresAs of commit 8a7c7bb with merge base 4db778e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
JacobSzwejbka
deployed
to
upload-benchmark-results
November 3, 2026 12:14 — with 
GitHub Actions
Active
GitHub Actions
Active
shoumikhin
approved these changes
Nov 3, 2026
JacobSzwejbka
added a commit
that referenced
this pull request
Nov 3, 2026
Supersedes #24324 with a clean release pick from #24314. Adds validated per-program CUDA weights filenames and lowerings for antialiased bilinear/bicubic resize. Retains the data-name validation, resize-test removal and documentation follow-ups already carried by #24324. Preserves the release behavior that mismatched CUDA weights fail to load. The resize rewrite follows the source PR tolerances rather than promising bit-identical floating-point results. ## Scope and landing order Land after #24488 in the verified landing order. This branch starts directly at release/1.6 commit `dfb78b9ecd933a5fee33ebc94f69ed4b71cbb1e7`. Its GitHub diff contains 10 files for this pick; it does not carry duplicate #24298 history or the excluded unmerged QNN work. Dependencies are documented here rather than embedded as other cherry-pick commits. ## Verification All changed Python files compile and pass Ruff F821 checks. All seven replacements merge cleanly in the documented sequence, including simulated squash merges. No QNN files are changed. Native CUDA, OpenVINO and portable C++ suites were not run locally on this macOS host; PR CI remains required before landing. Prepared with OpenAI Codex.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #24320 with a clean release pick from #24299.
Adds CUDA mask-index shims, corrects graph output layout and captured-shape handling, and checks bound output buffers against their upper bounds. Includes the graph retry, host-constant handling, allocation bookkeeping, input-shape checks and wheel shim-check follow-ups already carried by #24320.
The Windows import library preserves the existing release dtype-element-size export while adding the three source PR exports. Buffers smaller than the maximum planned output size and replays with changed input shapes are rejected.
Scope and landing order
First in the verified landing order; #24298 is already merged and remains the baseline.
This branch starts directly at release/1.6 commit
dfb78b9ecd933a5fee33ebc94f69ed4b71cbb1e7. Its GitHub diff contains 21 files for this pick; it does not carry duplicate #24298 history or the excluded unmerged QNN work. Dependencies are documented here rather than embedded as other cherry-pick commits.Verification
All changed Python files compile and pass Ruff F821 checks. All seven replacements merge cleanly in the documented sequence, including simulated squash merges. No QNN files are changed.
Native CUDA, OpenVINO and portable C++ suites were not run locally on this macOS host; PR CI remains required before landing.
Prepared with OpenAI Codex.