Repository navigation
Arm backend: Add CONST and use tosa dialect op - #24287
Open
AdrianLundell wants to merge 2 commits into
Open
AdrianLundell wants to merge 2 commits into
AdrianLundell wants to merge 2 commits into
Conversation
- Add a CONST dialect operation to TOSA dialect + helper function - Add explicit CONST shift to tosa.MUL - Add explicit CONST zero shift to tosa.NEGATE - Add explicit CONST pad values to tosa.PAD This will be used for 1-1 tosa graph serialization from exir graph, for now ignore dialect CONST nodes in the existing serializer flow Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I6e5ded885d02f8ca6a700c89786b8a68234e13cd
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24287
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit ed80e03 with merge base 87d6190 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
approved these changes
Oct 29, 2026
zingo
left a comment
Collaborator
There was a problem hiding this comment.
OK to merge I think this should be fine to merge as long as double checked/considered buck2 but as it borderline larke/many file I let you decide if you want an Meta check. E.g. this is fine to merge but if you think it makes sense lets ask.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be used for 1-1 tosa graph serialization from exir graph, for now ignore dialect CONST nodes in the existing serializer flow
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani