Skip to content

Arm backend: Add CONST and use tosa dialect op - #24287

Open
AdrianLundell wants to merge 2 commits into
pytorch:mainfrom
AdrianLundell:change-1377395
Open

AdrianLundell wants to merge 2 commits into
pytorch:mainfrom
AdrianLundell:change-1377395

Conversation

@AdrianLundell

@AdrianLundell AdrianLundell commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator
  • Add a CONST dialect operation to TOSA dialect + helper function
  • Add explicit CONST shift to tosa.MUL
  • Add explicit CONST zero shift to tosa.NEGATE
  • Add explicit CONST pad values to tosa.PAD

This will be used for 1-1 tosa graph serialization from exir graph, for now ignore dialect CONST nodes in the existing serializer flow

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

- Add a CONST dialect operation to TOSA dialect + helper function
- Add explicit CONST shift to tosa.MUL
- Add explicit CONST zero shift to tosa.NEGATE
- Add explicit CONST pad values to tosa.PAD

This will be used for 1-1 tosa graph serialization from exir graph,
for now ignore dialect CONST nodes in the existing serializer flow

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: I6e5ded885d02f8ca6a700c89786b8a68234e13cd
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Oct 29, 2026
@pytorch-bot

pytorch-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24287

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit ed80e03 with merge base 87d6190 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2026
@github-actions github-actions Bot added the module: arm Issues related to arm backend label Oct 29, 2026

@zingo zingo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge I think this should be fine to merge as long as double checked/considered buck2 but as it borderline larke/many file I let you decide if you want an Meta check. E.g. this is fine to merge but if you think it makes sense lets ask.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants