Skip to content

[executorch] Arm backend: Preserve Arm pass behavior for Conv1d conversion #22086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobSzwejbka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[executorch] Arm backend: Preserve Arm pass behavior for Conv1d conversion #22086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backends/arm/_passes/conv1d_unsqueeze_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from typing import Set, Type

from executorch.backends.arm._passes import ArmOpTargetedPass
from executorch.backends.arm._passes.convert_squeezes_to_view import (
ConvertSqueezesToViewPass,
)
Expand All @@ -15,14 +16,16 @@
from executorch.backends.transforms.convert_conv1d_to_conv2d_pass import (
ConvertConv1dToConv2dPass,
)
from executorch.exir.dialects._ops import ops as exir_ops
from executorch.exir.pass_base import ExportPass


class Conv1dUnsqueezePass(ConvertConv1dToConv2dPass):
class Conv1dUnsqueezePass(ConvertConv1dToConv2dPass, ArmOpTargetedPass):
"""Arm wrapper for the shared Conv1d-to-Conv2d transform."""

_passes_required_after: Set[Type[ExportPass]] = {
ConvertSqueezesToViewPass,
RewriteConvPass,
SizeAdjustInputPass,
}
target_ops = (exir_ops.edge.aten.convolution.default,)
17 changes: 17 additions & 0 deletions backends/arm/test/ops/test_conv1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ def forward(self, x):
return x


class Conv1dWithLeakyReLU(Conv1d):
def forward(self, x):
return torch.nn.functional.leaky_relu(super().forward(x), negative_slope=0.0)


conv1d_2_3x2x40_nobias = Conv1d(
in_channels=2,
out_channels=3,
Expand Down Expand Up @@ -327,6 +332,18 @@ def test_convolution_1d_tosa_INT(test_data):
pipeline.run()


def test_convolution_1d_with_leaky_relu_tosa_INT():
model = Conv1dWithLeakyReLU()
pipeline = TosaPipelineINT[input_t](
model,
model.get_inputs(),
[aten_op, "torch.ops.aten.leaky_relu.default"],
[exir_op, "executorch_exir_dialects_edge__ops_aten_leaky_relu_default"],
qtol=1,
)
pipeline.run()


@common.parametrize("test_data", test_data_INT)
@common.XfailIfNoCorstone300
def test_convolution_1d_u55_INT(test_data):
Expand Down
Loading