Pin ExecuTorch to the release/1.4 branch head#4434
Open
shoumikhin wants to merge 1 commit into
Open
Conversation
main pins the ExecuTorch dependency to the release/1.3 branch head (6118688a), which predates the shared extension_cuda caller-stream work. Bump the pin to the release/1.4 branch head (cd380e7aefd18c171271cc228d3a155455095219), the first ExecuTorch release line that contains both pytorch/executorch#20158 (shared extension_cuda caller-stream library) and pytorch/executorch#20498 (caller CUDA stream for H2D/D2H copies). This follows the existing convention of pinning a release-branch head commit; the new_git_repository rule takes a commit, not a branch name. The four Bazel files that pin ExecuTorch are updated identically: MODULE.bazel, docker/MODULE.bazel.docker, docker/MODULE.bazel.ngc, and toolchains/ci_workspaces/MODULE.bazel.tmpl. Swap the branch-head commit for the immutable v1.4.0 tag once ExecuTorch publishes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Torch-TensorRT pins ExecuTorch to a release-branch head, and ExecuTorch just cut
release/1.4. Bump the pin onmainfrom therelease/1.3head to therelease/1.4head so Torch-TensorRT tracks the latest ExecuTorch release line.Same one-line change in the four Bazel files that pin ExecuTorch (
MODULE.bazel,docker/MODULE.bazel.docker,docker/MODULE.bazel.ngc,toolchains/ci_workspaces/MODULE.bazel.tmpl):Follow-up: swap the branch-head commit for the
v1.4.0tag once ExecuTorch publishes it.