Repository navigation
Conversation
Compare dependency membership and counts when validating cache freshness. Dependency order can change when graph loading suppresses and restores imports. Add an integration regression for an unchanged second run using the namespace-package reproduction. Fixes python#22159.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22159.
The cache freshness check compared dependency lists positionally. Graph loading can suppress and restore dependencies in a different order, marking an unchanged module stale. The comparison now checks dependency membership and list cardinality, preserving the unique-dependency invariant and the existing suppressed-import option validation.
The regression case uses the reported namespace-package layout and verifies that an unchanged second run does not recheck
a.LLM assistance was used during reproduction, source tracing, and implementation; the behavior was verified with the regression case and incremental suite.
Verification:
pytest -n0 mypy/test/testbuild.py::BuildSuite::test_reuses_cache_when_dependency_order_changespytest -n0 'mypy/test/testcheck.py::TypeCheckSuite::check-incremental.test'(358 passed, 4 skipped)python runtests.py selfpython runtests.py lint