Skip to content

gh-161441: Fix tkinter and IDLE tests failing with new Tcl/Tk - #161442

Open
serhiy-storchaka wants to merge 2 commits into
python:mainfrom
serhiy-storchaka:gh-161441-tk-tests
Open

serhiy-storchaka wants to merge 2 commits into
python:mainfrom
serhiy-storchaka:gh-161441-tk-tests

Conversation

@serhiy-storchaka

Copy link
Copy Markdown
Member
  • Generated events are not delivered to widgets whose window does not exist yet. Realize the widgets before generating events for them.
  • A named font whose name is a font description was never supported. Remove the check for it.

🤖 Generated with Claude Code

* Generated events are not delivered to widgets whose window does not
  exist yet. Realize the widgets before generating events for them.
* A named font whose name is a font description was never supported.
  Remove the check for it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is an anomaly in that there is no 'editmenu.py' being tested. It was added in 2016 (GH-49374) to test the new fix_x11_paste function (then in pyshell.py). I think it is too much a tkinter rather than IDLE test; it was never expanded to other menu entries (and I don't expect to do so here). I intend to sometime delete it.

The new claude-generated test_util.FixText.test_fix_x11_paste tests the tct code bound to . Quite clever, but I want to also extract at least 1 python test from here. Hence leave for now and fix it to pass on all Tks.

@terryjreedy

Copy link
Copy Markdown
Member

Failed tests (3): iOS (free-threading) test.test_io.test_bufferedio.CBufferedTypeTest.test_garbage_collection where Type in [Random, Reader, Writer].
https://github.com/python/cpython/actions/runs/42094154159/job/127479865296?pr=161442
Seem unrelated, retrying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants