Repository navigation
Conversation
…ed to `setvar`
StanFromIreland
approved these changes
Nov 5, 2026
sobolevn
commented
Nov 5, 2026
sobolevn
commented
Nov 5, 2026
sobolevn
enabled auto-merge (squash)
November 5, 2026 19:55
sobolevn
added
needs backport to 3.14
Member
|
The fix LGTM, I have comments for tests and NEWS. |
sobolevn
disabled auto-merge
November 5, 2026 20:08
| setvar("name1", "name2", default) | ||
|
|
||
| self.assertRaises(TclError, getvar, "name1") | ||
| self.assertIsNone(setvar("name1", "name2")) |
Member
There was a problem hiding this comment.
I meant setvar("name1", default).
BTW, I would rename default to value.
| with self.assertRaisesRegex(RuntimeError, "setvar evil"): | ||
| setvar("name1", "name2", default) | ||
|
|
||
| self.assertRaises(TclError, getvar, "name1") |
Member
There was a problem hiding this comment.
It should pass "name1", "name2" if you want to check the value of $name1(name2).
|
|
||
| default = StrRaises() | ||
|
|
||
| for getvar, setvar, unsetvar in [ |
Member
There was a problem hiding this comment.
Would not the following be easier to read?
for prefix in '', 'global':
with self.subTest(...):
getvar = getattr(self.interp.tk.getvar, prefix + 'getvar')
...Or simply repeat these few lines like in other tests (with shortcut tk = self.interp.tk).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setvar()passesAsObj's NULL to Tcl when the value's__str__raises #161388