Skip to content

gh-161270: fix always-skipped InitConfigTests in test_embed #161278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NekoAsakura wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

gh-161270: fix always-skipped InitConfigTests in test_embed #161278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/test/test_embed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
print(f"stderr:\n{err}")
print("------")

self.assertEqual(p.returncode, returncode,

Check failure on line 174 in Lib/test/test_embed.py

View workflow job for this annotation

GitHub Actions / Sanitizers / UBSan

test_initconfig_api (test.test_embed.InitConfigTests.test_initconfig_api) 

AssertionError: 1 != 0 : bad returncode 1, stderr is 'Fatal Python error: Segmentation fault\n\nCurrent thread 0x00007b92db77f3c0 [_testembed] (most recent call first):\n\nCurrent thread\'s C stack trace (most recent call first):\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at _Py_DumpStack+0x32 [0x5b901382e60a]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x11cd6b3 [0x5b90138806b3]\n  Binary file "/usr/lib/x86_64-linux-gnu/libc.so.6", at +0x47e10 [0x7b92db447e10]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x119edd9 [0x5b9013851dd9]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xede652 [0x5b9013591652]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf5e21 [0x5b90131a8e21]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf8e65 [0x5b90131abe65]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd2d20f [0x5b90133e020f]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd60a6a [0x5b9013413a6a]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd133ab [0x5b90133c63ab]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at _PyObject_MakeTpCall+0x55b [0x5b90131a9523]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf9390 [0x5b90131ac390]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at PyObject_CallFunction+0x8f [0x5b90131ac077]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xf7b692 [0x5b901362e692]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x128bac1 [0x5b901393eac1]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x1281423 [0x5b9013934423]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd133ab [0x5b90133c63ab]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at _PyObject_MakeTpCall+0x55b [0x5b90131a9523]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf9b2e [0x5b90131acb2e]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at _PyObject_CallMethod+0xc9 [0x5b90131acff1]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x10e4a72 [0x5b9013797a72]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x10e379e [0x5b901379679e]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x10e2806 [0x5b9013795806]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x10da1b3 [0x5b901378d1b3]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at Py_InitializeFromConfig+0x2d0 [0x5b901378ceb8]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at Py_InitializeFromInitConfig+0x12d [0x5b9013746975]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x82ac69 [0x5b9012eddc69]\n  Binary file "/usr/lib/x86_64-linux-gnu/libc.so.6", at +0x2a8c1 [0x7b92db42a8c1]\n  Binary file "/usr/lib/x86_64-linux-gnu/libc.so.6", at __libc_start_main+0x88 [0x7b92db42a9d8]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at _start+0x25 [0x5b9012eabf65]\nUndefinedBehaviorSanitizer:DEADLYSIGNAL\n'

Check failure on line 174 in Lib/test/test_embed.py

View workflow job for this annotation

GitHub Actions / Sanitizers / UBSan

test_init_python_env (test.test_embed.InitConfigTests.test_init_python_env) 

AssertionError: 1 != 0 : bad returncode 1, stderr is 'import _frozen_importlib # frozen\nimport _imp # builtin\nimport \'_thread\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport \'_warnings\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport \'_weakref\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time: self [us] | cumulative | imported package\nimport \'_io\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       604 |        604 |   _io\nimport \'marshal\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       199 |        199 |   marshal\nimport \'posix\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:      1042 |       1042 |   posix\nimport \'_frozen_importlib_external\' # <class \'_frozen_importlib.FrozenImporter\'>\nimport time:      1856 |       3699 | _frozen_importlib_external\n# installing zipimport hook\nimport \'time\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       277 |        277 |   time\nimport \'zipimport\' # <class \'_frozen_importlib.FrozenImporter\'>\nimport time:      1306 |       1582 | zipimport\n# installed zipimport hook\nimport \'faulthandler\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       198 |        198 | faulthandler\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/__init__.py\n# code object from /home/runner/work/cpython/cpython/Lib/codecs.py\nimport \'_codecs\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       332 |        332 |     _codecs\nimport \'codecs\' # <_frozen_importlib_external.SourceFileLoader object at 0x5cf3b8e9cb50>\nimport time:     13176 |      13507 |   codecs\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/aliases.py\nimport \'encodings.aliases\' # <_frozen_importlib_external.SourceFileLoader object at 0x5cf3b8d96ea0>\nimport time:      6292 |       6292 |   encodings.aliases\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/_iconv_codecs.py\nimport \'encodings._iconv_codecs\' # <_frozen_importlib_external.SourceFileLoader object at 0x5cf3b8e9c870>\nimport time:      1633 |       1633 |   encodings._iconv_codecs\nimport \'encodings\' # <_frozen_importlib_external.SourceFileLoader object at 0x5cf3b8d81a20>\nimport time:      6092 |      27522 | encodings\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/utf_8.py\nimport \'encodings.utf_8\' # <_frozen_importlib_external.SourceFileLoader object at 0x5cf3b8da0a80>\nimport time:      2084 |       2084 | encodings.utf_8\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/latin_1.py\nimport \'encodings.latin_1\' # <_frozen_importlib_external.SourceFileLoader object at 0x5cf3b8e78340>\nimport time:      1402 |       1402 | encodings.latin_1\nimport \'_signal\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       307 |        307 | _signal\nFatal Python error: Segmentation fault\n\nCurrent thread 0x0000740b03d993c0 [_testembed] (most recent call first):\n\nCurrent thread\'s C stack trace (most recent call first):\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at _Py_DumpStack+0x32 [0x5cf37a34260a]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x11cd6b3 [0x5cf37a3946b3]\n  Binary file "/usr/lib/x86_64-linux-gnu/libc.so.6", at +0x47e10 [0x740b03a47e10]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x119edd9 [0x5cf37a365dd9]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xede652 [0x5cf37a0a5652]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf5e21 [0x5cf379cbce21]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf8e65 [0x5cf379cbfe65]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd2d20f [0x5cf379ef420f]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd60a6a [0x5cf379f27a6a]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd133ab [0x5cf379e

Check failure on line 174 in Lib/test/test_embed.py

View workflow job for this annotation

GitHub Actions / Sanitizers / UBSan

test_init_compat_env (test.test_embed.InitConfigTests.test_init_compat_env) 

AssertionError: 1 != 0 : bad returncode 1, stderr is 'import _frozen_importlib # frozen\nimport _imp # builtin\nimport \'_thread\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport \'_warnings\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport \'_weakref\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time: self [us] | cumulative | imported package\nimport \'_io\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       556 |        556 |   _io\nimport \'marshal\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       194 |        194 |   marshal\nimport \'posix\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:      1035 |       1035 |   posix\nimport \'_frozen_importlib_external\' # <class \'_frozen_importlib.FrozenImporter\'>\nimport time:      1858 |       3641 | _frozen_importlib_external\n# installing zipimport hook\nimport \'time\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       274 |        274 |   time\nimport \'zipimport\' # <class \'_frozen_importlib.FrozenImporter\'>\nimport time:      1295 |       1568 | zipimport\n# installed zipimport hook\nimport \'faulthandler\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       179 |        179 | faulthandler\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/__init__.py\n# code object from /home/runner/work/cpython/cpython/Lib/codecs.py\nimport \'_codecs\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       312 |        312 |     _codecs\nimport \'codecs\' # <_frozen_importlib_external.SourceFileLoader object at 0x5d5c7abb8b50>\nimport time:     13224 |      13536 |   codecs\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/aliases.py\nimport \'encodings.aliases\' # <_frozen_importlib_external.SourceFileLoader object at 0x5d5c7aab2ea0>\nimport time:      6306 |       6306 |   encodings.aliases\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/_iconv_codecs.py\nimport \'encodings._iconv_codecs\' # <_frozen_importlib_external.SourceFileLoader object at 0x5d5c7abb8870>\nimport time:      1628 |       1628 |   encodings._iconv_codecs\nimport \'encodings\' # <_frozen_importlib_external.SourceFileLoader object at 0x5d5c7aa9da20>\nimport time:      6308 |      27777 | encodings\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/utf_8.py\nimport \'encodings.utf_8\' # <_frozen_importlib_external.SourceFileLoader object at 0x5d5c7aabca80>\nimport time:      2007 |       2007 | encodings.utf_8\n# code object from /home/runner/work/cpython/cpython/Lib/encodings/latin_1.py\nimport \'encodings.latin_1\' # <_frozen_importlib_external.SourceFileLoader object at 0x5d5c7ab94340>\nimport time:      1374 |       1374 | encodings.latin_1\nimport \'_signal\' # <class \'_frozen_importlib.BuiltinImporter\'>\nimport time:       323 |        323 | _signal\nFatal Python error: Segmentation fault\n\nCurrent thread 0x00007cefe15503c0 [_testembed] (most recent call first):\n\nCurrent thread\'s C stack trace (most recent call first):\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at _Py_DumpStack+0x32 [0x5d5c6f03760a]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x11cd6b3 [0x5d5c6f0896b3]\n  Binary file "/usr/lib/x86_64-linux-gnu/libc.so.6", at +0x47e10 [0x7cefe1247e10]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0x119edd9 [0x5d5c6f05add9]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xede652 [0x5d5c6ed9a652]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf5e21 [0x5d5c6e9b1e21]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xaf8e65 [0x5d5c6e9b4e65]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd2d20f [0x5d5c6ebe920f]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd60a6a [0x5d5c6ec1ca6a]\n  Binary file "/home/runner/work/cpython/cpython/Programs/_testembed", at +0xd133ab [0x5d5c6eb
"bad returncode %d, stderr is %r" %
(p.returncode, err))
return out, err
Expand Down Expand Up @@ -1107,7 +1107,7 @@
self.check_global_config(configs)
return configs

@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
@unittest.skipIf(support.check_bolt_optimized(), "segfaults on BOLT instrumented binaries")
def test_init_default_config(self):
self.check_all_configs("test_init_initialize_config", api=API_COMPAT)

Expand Down Expand Up @@ -1195,7 +1195,7 @@
self.check_all_configs("test_init_from_config", config, preconfig,
api=API_COMPAT)

@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
@unittest.skipIf(support.check_bolt_optimized(), "segfaults on BOLT instrumented binaries")
def test_init_compat_env(self):
preconfig = {
'allocator': ALLOCATOR_FOR_CONFIG,
Expand Down Expand Up @@ -1231,7 +1231,7 @@
self.check_all_configs("test_init_compat_env", config, preconfig,
api=API_COMPAT)

@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
@unittest.skipIf(support.check_bolt_optimized(), "segfaults on BOLT instrumented binaries")
def test_init_python_env(self):
preconfig = {
'allocator': ALLOCATOR_FOR_CONFIG,
Expand Down Expand Up @@ -1955,7 +1955,7 @@
self.check_all_configs("test_init_warnoptions", config, preconfig,
api=API_PYTHON)

@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
@unittest.skipIf(support.check_bolt_optimized(), "segfaults on BOLT instrumented binaries")
def test_initconfig_api(self):
preconfig = {
'configure_locale': True,
Expand Down
Loading