Repository navigation
Conversation
…n Windows The stable ABI forwarder DLLs are linked with /NOENTRY, so nothing pulls in the CRT. With AddressSanitizer enabled, the linker adds the ASan runtime thunk library, which needs the CRT, and the link fails with unresolved symbols. Keep the default CRT entry point for these DLLs when building with ASan.
|
All commit authors signed the Contributor License Agreement. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
picnixz
added
the
AI-needs-explanation
|
Thank you for your interest in contributing to Python. This is a community-driven project, and we want it to be a welcoming place to learn and collaborate. Contributors are responsible for reviewing and understanding what they submit, checking its claims, and being able to explain changes in their own words. This helps reviewers focus on the contribution and leaves more time to support other contributors. This contribution appears to have been authored with AI assistance. Please explain your contribution in your own words and describe how you checked its correctness. Please read our guidelines for using AI tools. |
|
LGTM, but see my earlier #150467 (comment) before we proceed here. |
|
Agreed, made some changes regarding the comment you linked. Thanks. |
Fixes gh-150467.
Root cause
python3.dll and python3t.dll only contain
/EXPORTforwarders and are linked with/NOENTRY, so the CRT is never pulled in. With ASan enabled, the linker addsclang_rt.asan_dynamic_runtime_thunk, which needs the CRT (_initterm,abort,__vcrt_*,__acrt_*), so the link fails with LNK2001.python3.dll also fails this way at the parent of GH-149218, so the bug is older. That change added python3t.dll, a second forwarder built with the same settings.
Fix
python3dll.vcxprojandpython3tdll.vcxprojnow setNoEntryPointonly whenEnableASANisn'ttrue, so ASan builds keep the default CRT entry point. ASan turned on only through_CL_/_LINK_is not detected; use/p:EnableASAN=true.Non-ASan builds are unchanged: both DLLs still have no entry point and no imports.
Testing
x64 Release, VS 2026 (MSVC 14.51), building
python3dll.vcxprojandpython3tdll.vcxprojon their own:/p:EnableASAN=true: both failed with LNK2001 before, and link now.dumpbinshows_DllMainCRTStartupas the entry point and an import ofclang_rt.asan_dynamic-x86_64.dll.