Repository navigation
gh-159136: Keep eval-frame recorded function names alive - #160836
Merged
nascheme merged 1 commit intoOct 29, 2026
Merged
Conversation
Hold a strong reference to func_name in both recording hooks before PyList_Append can detach while acquiring the recording list lock.
nascheme
added
type-bug
kumaraditya303
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold a strong reference to func_name in both recording hooks before PyList_Append can detach while acquiring the recording list lock.
Note, this should not need to be backported, it's included in backported PRs for the gh-159136 issue.
__name__/__doc__stops the world;functools.wrapsfrom multiple threads is orders of magnitude slower since 3.14.7 #159136