Repository navigation
[3.15] gh-160704: Restore C11-C17 static_assert fallback (GH-160705) - #160825
Merged
Merged
Conversation
…60705) `_Py_STDC_VERSION` needs to be defined before its value can be checked. In 8335bcb (pythongh-160208: Add a private wrapper around __STDC_VERSION__ (pythonGH-160376), 2026-10-23), the condition `defined(_Py_STDC_VERSION)` is incorrectly negated, which prevents the fallback definition of `static_assert` in C11-C17 builds and causes a build error when building with an old C library that does not define `static_assert`. (cherry picked from commit a7ac7a8) Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com> Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Py_STDC_VERSIONneeds to be defined before its value can be checked.In 8335bcb (gh-160208: Add a private wrapper around STDC_VERSION
(GH-160376), 2026-10-23), the condition
defined(_Py_STDC_VERSION)isincorrectly negated, which prevents the fallback definition of
static_assertin C11-C17 builds and causes a build error when buildingwith an old C library that does not define
static_assert.(cherry picked from commit a7ac7a8)
Co-authored-by: Ruoyu Zhong zhongruoyu@outlook.com
Signed-off-by: Ruoyu Zhong zhongruoyu@outlook.com
static_assertfallback regression #160704