Repository navigation
Conversation
gpshead
added
needs backport to 3.14
reset() returned early when nothing was pending, so the shift-back sequence of hz and iso2022_* was never written (regression from pythongh-67436). Also fix a reference leak of the stream.write() result.
gpshead
force-pushed
the
cjk-streamwriter-reset
branch
from
October 22, 2026 04:44
345ec10 to
d86d637
Compare
gpshead
marked this pull request as ready for review
October 22, 2026 05:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultibyteStreamWriter.reset()now passes an empty string to the encoder when nothing is pending instead of returning early, so the codec's reset hook writes the shift-back sequence again, as it did before gh-67436. It also drops the leakedstream.write()result.Since
reset()can now write bytes,StreamWriter.seek(),StreamReaderWriter.seek()andStreamRecoder.seek()reset the writer before moving the stream; otherwiseseek(0)would writeESC ( Bover offset 0. Other codecs'StreamWriter.reset()writes nothing, so the reorder doesn't change them.Fixes #160185
ANT-2026-4AU4SRS4