Repository navigation
Conversation
…sions Include the client's certificate when the session was resumed from a ticket, and return [] instead of raising AttributeError when the client sent no certificate.
gpshead
added
needs backport to 3.14
Documentation build overview
13 files changed ·
|
picnixz
reviewed
Oct 22, 2026
Comment on lines
+1299
to
+1300
| The verified chain is not stored with a session, so the list is empty | ||
| when the session was resumed (see :attr:`~SSLSocket.session_reused`). |
Member
There was a problem hiding this comment.
Suggested change
| The verified chain is not stored with a session, so the list is empty | |
| when the session was resumed (see :attr:`~SSLSocket.session_reused`). | |
| The verified chain is not stored with a session, so the list is empty | |
| when the session is resumed (see :attr:`~SSLSocket.session_reused`). |
Comment on lines
+5718
to
+5719
| # TODO: sessions aren't compatible with TLSv1.3 yet | ||
| client_context.maximum_version = ssl.TLSVersion.TLSv1_2 |
Member
There was a problem hiding this comment.
Is it the case? I thought that we had a session resumption for 1.3
| ) as s: | ||
| s.connect((HOST, server.port)) | ||
| self.assertTrue(s.session_reused) | ||
| s.write(b'UNVERIFIEDCHAIN\n') |
Member
There was a problem hiding this comment.
Can we have a test with the VERIFIEDCHAIN callback?
| X509 *peer = SSL_get_peer_certificate(self->ssl); | ||
|
|
||
| if (peer == NULL) { | ||
| peerobj = Py_NewRef(Py_None); |
Member
There was a problem hiding this comment.
So this is changed right? we're never having a list with a single None? I think we should just document that [None] is no longer possible to be returned.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the server side, decide whether there is a client certificate from
SSL_get_peer_certificate()rather than from the chain, and treat a NULL chain as empty, so a ticket-resumed session reports the client's certificate and a client without one gives[]instead of[None]. A session ticket only stores the peer certificate, so intermediates are still missing after resumption andget_verified_chain()is empty on any resumed connection; the docs now say so. The test echo server now calls the public methods and replies with the exception instead of dying, so a regression fails instead of hanging.Fixes #160171
ANT-2026-2RMA0IPV