gh-153477: Fix IDLE startup crash on a corrupt user config file#153478
Open
tonghuaroot wants to merge 2 commits into
Open
gh-153477: Fix IDLE startup crash on a corrupt user config file#153478tonghuaroot wants to merge 2 commits into
tonghuaroot wants to merge 2 commits into
Conversation
IdleConfParser.Load raised the configparser exception on a corrupt or partially written user configuration file, which aborted IDLE startup. Catch it, warn, and fall back to the default configuration, matching the module's documented graceful-degradation behavior.
Wulian233
reviewed
Jul 10, 2026
| self.assertEqual(parser.GetOptionList('Foo Bar'), ['foo']) | ||
|
|
||
| def test_load_invalid_file(self): | ||
| # gh-000000: a corrupt config file must warn and fall back to |
Contributor
There was a problem hiding this comment.
Suggested change
| # gh-000000: a corrupt config file must warn and fall back to | |
| # gh-153478: a corrupt config file must warn and fall back to |
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed in 0a94b48. Used the issue number gh-153477 to match the commit subject and the NEWS entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdleConfParser.Loadcalledconfigparser'sread_filewith no error handling, so a corrupt or partially written user configuration file (for example one left behind by an interruptedSave) raised aconfigparser.Errorsuch asMissingSectionHeaderErrorand aborted IDLE startup. This contradicts the graceful-degradation behavior documented in theconfig.pymodule docstring.Loadnow catchesconfigparser.Error, warns to stderr, and falls back to the default configuration. The regression test writes a headerless config file and checks thatLoadwarns and leaves the parser empty instead of raising.