gh-153305: Fix dbm.whichdb docstring return-value example#153306
Open
tonghuaroot wants to merge 2 commits into
Open
gh-153305: Fix dbm.whichdb docstring return-value example#153306tonghuaroot wants to merge 2 commits into
tonghuaroot wants to merge 2 commits into
Conversation
whichdb() returns the dotted submodule name, such as "dbm.ndbm" or "dbm.gnu", matching the keys of the internal dispatch table and the values documented in Doc/library/dbm.rst. The docstring still showed the pre-package "ndbm"/"gnu" form. Correct the example.
tonghuaroot
requested review from
corona10,
erlend-aasland and
serhiy-storchaka
as code owners
aisk
approved these changes
Jul 8, 2026
Comment on lines
+105
to
+106
| - the name of the dbm submodule (e.g. "dbm.ndbm" or "dbm.gnu") if | ||
| recognized. |
Member
There was a problem hiding this comment.
Suggested change
| - the name of the dbm submodule (e.g. "dbm.ndbm" or "dbm.gnu") if | |
| recognized. | |
| - the name of the dbm submodule (for example "dbm.ndbm" or "dbm.gnu") | |
| if recognized. |
While we're here, let's update this to be compliant with our style guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbm.whichdb()returns the dotted submodule name ("dbm.ndbm","dbm.gnu","dbm.sqlite3","dbm.dumb"), matching the keys of the internal dispatchtable and the values already documented in
Doc/library/dbm.rst. Thedocstring example still used the pre-package
"ndbm"/"gnu"form. Thiscorrects the example only.
Documentation-only change; no behavior change and no test needed.