[3.10] gh-151987: Pass filter_function to TarFile._extract_one() during .extract() (GH-151988)#152613
Open
miss-islington wants to merge 2 commits into
Open
[3.10] gh-151987: Pass filter_function to TarFile._extract_one() during .extract() (GH-151988)#152613miss-islington wants to merge 2 commits into
miss-islington wants to merge 2 commits into
Conversation
…g .extract() (pythonGH-151988) (cherry picked from commit 7ccdbab) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Seth Michael Larson <seth@python.org>
This was referenced Jun 29, 2026
Member
|
@encukou this is breaking tests in 3.10 |
3.11+ has more granular platform support, mostly for WASI. Use the 3.10 idioms instead: - @symlink_test is a no-op on non-WASI platforms - can_chmod is approximated by "not win32" elsewhere in test_tarfile
Member
|
Thanks for the catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7ccdbab)
Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Seth Michael Larson seth@python.org