gh-148695: Lint warnings in cases generator, ceval with GIL, and optimizer.#148696
gh-148695: Lint warnings in cases generator, ceval with GIL, and optimizer.#148696clin1234 wants to merge 7 commits into
Conversation
clin1234
requested review from
Fidget-Spinner,
ericsnowcurrently and
markshannon
as code owners
| def push_cache(self, op_name: str, cached_items:list[str], outputs: int, out: CWriter) -> None: | ||
| for i, name in enumerate(cached_items): | ||
| out.start_line() | ||
| if (op_name == "_CALL_TYPE_1" and outputs == 2) \ |
There was a problem hiding this comment.
I think this is too fragile. Can't we just have a maybe unused attribute instead? and what about clang attributes? (AFAICT this is a GCC attribute only).
I do not think the unused variable warnings need to be suppressed.
There was a problem hiding this comment.
Can the Py_UNUSED macro be applied to lvalue variables?
There was a problem hiding this comment.
I don't think so. But again is there a need to suppress such warnings? we provide no guarantee for -Wall -Werror/-Wpedantic and I do not see value in suppressing unused variable warninga in general.
|
@picnixz @StanFromIreland @hugovk @vstinner @ericsnowcurrently @markshannon @Fidget-Spinner, comments on this PR? |
|
@clin1234 please do not randomly ping people. After three months you can post a little review reminder, but don't ping people (like me) who aren't CODEOWNERs of these files, unless they expressed interest in this earlier. |
3 participants
Uh oh!
There was an error while loading. Please reload this page.