Repository navigation
Drop support for py310 - #3594
EmmanuelNiyonshuti wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (98.12334%) is below the target coverage (100.00000%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3594 +/- ##
===================================================
- Coverage 98.16743% 98.12334% -0.04409%
===================================================
Files 128 128
Lines 19972 19929 -43
Branches 1399 1359 -40
===================================================
- Hits 19606 19555 -51
- Misses 359 362 +3
- Partials 7 12 +5
🚀 New features to boost your workflow:
|
|
All of these tests passes locally? I suspect one particular test failing. |
Ah, I can reproduce! forgot --runs-slow |
|
switching back to using Unpack in: trio/src/trio/_core/_entry_queue.py Lines 174 to 178 in 7e0dc2d does jedi not support * syntax? |
|
Not sure why you're mass-replacing |
Yes, but it's the preferred type to use moving forward for this. |
|
|
||
| # conflicts with formatter (ruff recommends these be disabled) | ||
| "missing-trailing-comma", # COM812 | ||
| "non-pep646-unpack" # (UP044) ignoring it for now(See: https://github.com/python-trio/trio/pull/3594#issuecomment-6898086470) |
There was a problem hiding this comment.
This should be removed once jedi supports * unpack operator.
|
Bumping minimum Python version to 3.11. LMK about anything I might have missed.