Skip to content

Stop accepting nan as much. - #3590

Merged
A5rocks merged 4 commits into
python-trio:mainfrom
A5rocks:no-more-nan
Nov 13, 2026
Merged

A5rocks merged 4 commits into
python-trio:mainfrom
A5rocks:no-more-nan

Conversation

@A5rocks

@A5rocks A5rocks commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #3578

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (93e6b2e) to head (089c979).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3590   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19555        19588   +33     
  Branches         1330         1335    +5     
===============================================
+ Hits            19555        19588   +33     
Files with missing lines Coverage Δ
src/trio/_core/_mock_clock.py 100.00000% <100.00000%> (ø)
src/trio/_core/_run.py 100.00000% <100.00000%> (ø)
src/trio/_core/_tests/test_mock_clock.py 100.00000% <100.00000%> (ø)
src/trio/_dtls.py 100.00000% <100.00000%> (ø)
src/trio/_highlevel_open_tcp_stream.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_dtls.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_highlevel_open_tcp_stream.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_testing.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CoolCat467 CoolCat467 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than a small nitpick

Comment thread src/trio/_core/_mock_clock.py Resolved
@A5rocks
A5rocks enabled auto-merge (squash) November 13, 2026 14:46
@A5rocks
A5rocks disabled auto-merge November 13, 2026 14:46
@A5rocks
A5rocks enabled auto-merge (squash) November 13, 2026 14:52
@A5rocks
A5rocks merged commit 7e0dc2d into python-trio:main Nov 13, 2026
146 of 150 checks passed
@A5rocks
A5rocks deleted the no-more-nan branch November 14, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MockClock.jump() accepts NaN and corrupts the clock

2 participants