Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| from social_core.exceptions import AuthException | ||
|
|
||
| if TYPE_CHECKING: | ||
| from social_core.backends.azuread import AzureADOAuth2 |
| if TYPE_CHECKING: | ||
| from social_core.backends.azuread import AzureADOAuth2 | ||
|
|
||
| from .oauth import OAuth2Test |
| and parsed.path.strip("/") | ||
| ): | ||
| return authority_url.rstrip("/") | ||
| except ValueError: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2041 +/- ##
==========================================
+ Coverage 91.75% 91.90% +0.14%
==========================================
Files 356 357 +1
Lines 16160 16354 +194
Branches 821 832 +11
==========================================
+ Hits 14828 15030 +202
+ Misses 1089 1082 -7
+ Partials 243 242 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure integrations need matching endpoints for their sign-in audience, optional PKCE and provider logout without custom backends. Preserve existing defaults and keep refreshed credentials and expiry in sync.
Fixes #748
Fixes #751
Fixes #814
Fixes #1929
Refs #459
Refs #1928