fix: support Python 3.14 removal of _const_node_type_names from ast#839
Open
muhamedfazalps wants to merge 1 commit into
Open
fix: support Python 3.14 removal of _const_node_type_names from ast#839muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
Python 3.14 removed the internal _const_node_type_names mapping from the ast module and uses ast.Constant for all constant node types. The existing fallback only supported Python < 3.8, causing an ImportError on Python >= 3.14. Split the fallback into two paths: - Python >= 3.14: map all constant types to 'Constant' - Older Python: keep the legacy type names (NameConstant, Num, Str, etc.) Fixes python-rope#836.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #836
Python 3.14 removed the internal
_const_node_type_namesmapping from theastmodule. The existing fallback only supported Python < 3.8, causing rope to fail on Python >= 3.14.This fix splits the fallback:
ConstantAll 70 tests pass.