Conversation
r3wretrhy
force-pushed
the
fix-utils-quoted-path-dep
branch
from
September 10, 2026 02:28
07fb9f3 to
f1e29b3
Compare
sourcery-ai
Bot
dismissed
their stale review
September 10, 2026 02:28
Sourcery withdrew this approval because the latest commits introduced blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequirementsParser._parse_pathpassed the requirement string toPath()as-is. A quoted local path with spaces such as"./foo bar"therefore looked up a name that included the quote characters and was not treated as a path.Strip a matching outer
'or"pair before the exists/absolute checks. Unquoted paths are unchanged.The added tests fail on the unpatched tree and pass with the change.