Correct padded HEADERS length and reject padding over fixed fields - #170
Open
vitalivo wants to merge 1 commit into
Open
Correct padded HEADERS length and reject padding over fixed fields#170vitalivo wants to merge 1 commit into
vitalivo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a padded HEADERS frame drops the pad-length byte from
body_len. This also rejects a valid frame containing only padding and an empty header block. Separately, HEADERS with PRIORITY and PUSH_PROMISE can accept padding that overlaps their fixed fields.Keep the full HEADERS body length and compare padding against the bytes available after the fixed fields. Regression cases cover zero/nonzero padding, empty/nonempty header blocks, both priority modes, and overlapping fixed fields in both frame types.
All 14 regression cases fail before the fix. Full Python 3.12 suite: 162 passed, 100% branch coverage. Ruff and strict mypy pass. Includes a changelog entry.