Repository navigation
Recognize forward slashes in Windows shell command completion - #1830
Merged
tleonhardt merged 1 commit intoNov 18, 2026
Conversation
timothyanderson096-ocdealcheck
requested review from
kmvanbrunt and
tleonhardt
as code owners
November 18, 2026 01:49
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 23 23
Lines 6665 6665
=======================================
Hits 6649 6649
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
tleonhardt
approved these changes
Nov 18, 2026
tleonhardt
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @timothyanderson096-ocdealcheck!
Your change appears to fix both case in #1820.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a forward slash is a valid path separator. Shell completion treated
./myas a bare command name, so an executable inPATHcould win over the one in the current directory. Absolute paths could also lose their directory. The path check now recognizes both separators and routes these inputs to the existing path completer.The regression tests use real directories and executables with Windows separator settings. Both cases failed on main and passed with the fix. On Linux with CPython 3.15.2, all 155 completion tests passed.
make testpassed 3,082 tests with three skips, andmake checkandmake docs-testpassed. The native Windows result remains for hosted CI.Prepared and tested with OpenAI Codex.
Timothy Anderson · Spotted Ridge Engineering / OC Labs · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence
Closes #1820.