Conversation
Contributor
|
Thanks @saitakarcesme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document
set_source(..., depends=[...])for project-local headers and distinguish it frominclude_dirs. A header can be found when compiling in the working tree but be absent when a wheel is built from an sdist. The overview example now declarespi.has a dependency and includes the project directory in the compiler search path.Fixes #168, following the discussion's preference to document the existing setuptools keyword.
Validation: built a minimal CFFI project through sdist → wheel with the checked-out CFFI. Without
depends,pi.hwas absent from the tarball and compilation failed; with it, the wheel built successfully, installed, and its C function returned the expected result. Both cases usedinclude_dirs=['.'].sphinx-build -W -b html doc/source doc/build/htmlandgit diff --checkpass.Disclosure: documentation and build verification prepared using OpenAI Codex in an authorized automated contribution session.