Improve astuple performance for nested atomic sequences - #1636
Open
Johnny-Kao wants to merge 2 commits into
Open
Johnny-Kao wants to merge 2 commits into
Johnny-Kao wants to merge 2 commits into
Conversation
Johnny-Kao
marked this pull request as ready for review
October 1, 2026 18:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid calling
has()for values whose exact type is already known to be atomic whenattrs.astuple()traverses a nested sequence.The top-level path already skips attrs detection for
_ATOMIC_TYPES; this applies the same shortcut to sequence elements while preserving the existing fallback for all non-atomic values.Benchmark
Local CPython 3.14 benchmark on
list[int]:A CodSpeed benchmark for nested atomic sequences is included.
Testing
uv run pytest -q: 1407 passed, 4 skipped, 2 xfaileduv run pytest bench/test_benchmarks.py::test_astuple_nested_atomic -quv run ruff check src/attr/_funcs.py bench/test_benchmarks.pyuv run ruff format --check src/attr/_funcs.py bench/test_benchmarks.pygit diff --checkPull Request Checklist