Repository navigation
👷 ci: dry-run the release in the PR gate - #293
Merged
Merged
Conversation
Release preparation installs prek hooks under the seven-day cooldown, links fragments and builds the changelog; no pull request check did, so a change could merge green and fail the next release (simplint#55). The gate now calls the prepare workflow with dry-run, which assembles the release and skips the push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request could merge green and still break the next release. Release preparation assembles under rules no pull request check applied: prek hooks install with packages from the last seven days held back, fragments link to their pull requests, and the changelog builds and formats. simplint#55 merged with every check green, and the next release failed while installing its hooks. 🚦
The required gate now runs this repository's own prepare workflow as a dry run, through the
dry-runinput added in github-workflows 6.6.0. The dry run uses the same inputs and the same assembly as a real release and skips the push job. A pull request that would break the release now fails its gate instead. The dry run needs no App key, and it has its own concurrency group, so it never queues behind a real release.Releases dispatched by hand behave as before.