Repository navigation
📝 docs(contributing): add a test policy - #292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributors had no written rule on whether a pull request needs a test, so reviewers asked for them case by case. CONTRIBUTING now states it: every new feature and bug fix comes with a test, a fix with one that fails without it, and a change without a test explains why in the pull request description. 📝
The section also says how to run the suite through
tox, that it enforces full coverage, and how to select a subset. This answers the OpenSSF Best Practicestest_policycriterion with a link maintainers can cite.